OCCT3D
DiscussionsIssue archiveOCCT:Data Exchange

Archived issue #0031550

Data Exchange, STEP Import - surface transparency is ignored (SURFACE_STYLE_TRANSPARENT)

CommunityOCCT:Data Exchangeclosed17 public notes

Search issues

Description

SURFACE_STYLE_TRANSPARENT entity is ignored by STEP reader leading to translucent entities like building windows being displayed as opaque.

The entity might look like this:
#7612=PRESENTATION_LAYER_ASSIGNMENT('61','Layer 61',(#7611));
#7613=COLOUR_RGB('',0.6,0.4,0.4);
#7614=FILL_AREA_STYLE_COLOUR('',#7613);
#7615=FILL_AREA_STYLE('',(#7614));
#7616=SURFACE_STYLE_FILL_AREA(#7615);
#7617=SURFACE_STYLE_TRANSPARENT(0.7);
#7618=SURFACE_STYLE_RENDERING_WITH_PROPERTIES(.NORMAL_SHADING.,#7613,(#7617));
#7619=SURFACE_SIDE_STYLE('',(#7616,#7618));
#7620=SURFACE_STYLE_USAGE(.BOTH.,#7619);
#7621=PRESENTATION_STYLE_ASSIGNMENT((#7620));
#7622=STYLED_ITEM('',(#7621),#7611)

Steps to reproduce

Existing test case using within non-zero SURFACE_STYLE_TRANSPARENT (screenshot is not created by test).
test bugs xde bug29525 1
vinit View1
XDisplay -dispMode 1 D
vfit

Public activity

17 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Commenter 3 Khozhanov
Date: Sun May 17 17:32:19 2020 +0300

    Implemented reading and writing of the surface transparency to/from step files
02Commenter 2
Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]
03Commenter 3
test bugs step bug31550
04Commenter 3
Dear Galina, please review branch CR31550

05Commenter 5
Branch CR31550 was reviewed
06Commenter 4
Dear Commenter 3,

// Created by: Commenter 3
I think such autogenerated line in stamps of new files doesn't look good. Could you please replace it with Name SURNAME?
After these changes please assign the issue to me, I will start auto testing.

07Commenter 2
Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]
08Author
--- /dev/null
+++ b/src/RWStepVisual/RWStepVisual_RWSurfaceStyleReflectanceAmbient.cxx
@@ -0,0 +1,78 @@
+// Created on : Thu May 14 15:13:19 2020 
+// Created by: Commenter 3 KHOZHANOV
+// Generator:  Express (EXPRESS -> CASCADE/XSTEP Translator) V2.0
...
+#include <Interface_EntityIterator.hxx>

Was this file generated or manually edited?
In the latter case, please make sure that class header (RWStepVisual_RWSurfaceStyleReflectanceAmbient.hxx in this case) is included first in new .cxx files. It is also desired removing trailing spaces in new files.

09Commenter 2
Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]
10Commenter 3
kgv, the files are generated. I didn't change the order of includes manually. Ok, I will do it. Could you please explain why the class header should be first?
11Author
> Could you please explain why the class header should be first?
I hope that you have started development from reading OCCT Coding Rules:
https://dev.opencascade.org/doc/overview/html/occt_dev_guides__coding_rules.html#occt_coding_rules_3

> Headers order
> ...
> Inclusion of class header on top verifies consistency of the header (e.g. that header file does not use any undefined declarations due to missing includes of dependencies).
12Commenter 2
Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]
13Commenter 3
All notes are implemented
14Commenter 2
Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]
15Commenter 4
Dear Commenter 1,

the issue was tested:
http://occt-tests/CR31550-master-Commenter 3-OCCT/Windows-64-VC14/diff_summary.html
Failed cases are not affected by the changes and are not regressions of this issue
http://occt-tests/CR31550-master-Commenter 3-OCCT/Debian80-64/diff_summary.html
OK
http://occt-tests/CR31550-master-Commenter 3-Products/Windows-64-VC14/diff_summary.html
these ifc cases fail on several branches, not affected by the current changes and not regressions
http://occt-tests/CR31550-master-Commenter 3-Products/Debian80-64/diff_summary.html
OK

branch is ready to be integrated
OCCT - CR31550
Products - NOT
16Commenter 1
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17169.13000000018 / 17197.13000000017 [-0.16%]
Products
Total CPU difference: 11217.810000000067 / 11198.660000000078 [+0.17%]
Windows-64-VC14:
OCCT
Total CPU difference: 18640.75 / 18655.984375 [-0.08%]
Products
Total CPU difference: 13006.1875 / 13006.671875 [-0.00%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
17Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records