Codig Rules, OMFAlgo - replace TCollection templates with NCollection

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Jun 29 10:35:07 2020 +0300

    0031636: Codig Rules - eliminate dead code TCollection_Array1.lxx

Branch [archived branch] has been created by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Jun 29 10:35:07 2020 +0300

    0031636: Codig Rules - eliminate dead code TCollection_Array1.lxx
    
    (cherry picked from [revision removed])

Branch [archived branch] has been updated by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Wed Oct 28 16:03:10 2020 +0300

    Removed TCollection_SeqNode.hxx and TCollection_SeqNodePtr.hxx

Branch [archived branch] has been created by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Jun 29 10:35:07 2020 +0300

    0031636: Codig Rules - eliminate dead code TCollection_Array1.lxx

+OMFAlgo_List.gxx
+OMFAlgo_List.lxx
+OMFAlgo_ListIterator.gxx
+OMFAlgo_ListIterator.lxx
...
+#define OMFAlgo_DataMap_hxx <OMFAlgo_DataMapOfIntegerMapOfInteger.hxx>
+#include <OMFAlgo_DataMapIterator.gxx>
...

.lxx and .gxx files are remnants of the past - there should be no need in adding new .lxx files (except for large header-only templates) and should be a better way then defining .gxx files.

+template <class TheKey, class TheItem, class TheHasher>
+class OMFAlgo_DataMap : public TCollection_BasicMap

Class description is missing.
It is unclear how this template is different from NCollection_DataMap and similar maps.

The same is for OMFAlgo_List - why not using NCollection_List?

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

Please try to get rid of redundant map collections.

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

OCCT branch: [archived branch]
Products branch: [archived branch]

Please raise the patch
- OCCT branch: [archived branch]
- Products branch: [archived branch]

http://jenkins-test-12.nnov.opencascade.com:8080/view/master-CR31636_3-KGV/

Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18024.090000000127 / 17964.340000000077 [+0.33%]
Products
Total CPU difference: 12166.12000000011 / 12169.520000000111 [-0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19696.90625 / 19723.125 [-0.13%]
Products
Total CPU difference: 13644.875 / 13567.078125 [+0.57%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

Fix has been integrated into master of occt-products repository

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]