Archived issue #0031658
Inspector - using AIS_ViewController in View package
Description
Replace mouse actions processing by connection to AIS_ViewController.
Public activity
11 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Jul 6 19:41:36 2020 +0300
0031658: Inspector - using AIS_ViewController in View package
- View: using AIS_ViewController, AIS_ViewCube.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Jul 6 19:41:36 2020 +0300
0031658: Inspector - using AIS_ViewController in View package
- View: using AIS_ViewController, AIS_ViewCube.
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Dear Kirill
could you please check the patch.
Thank you a lot, Natalia
could you please check the patch.
Thank you a lot, Natalia
+ myController->HandleViewEvents (myViewer->GetContext(), myViewer->GetView()); + myController->FlushViewEvents (myViewer->GetContext(), myViewer->GetView(), Standard_True);
It looks strange calling HandleViewEvents() before FlushViewEvents() considering that FlushViewEvents() with flag TRUE calls HandleViewEvents() internally.
Is there some reason for that?
+private: + //! Converts Qt modifier key to Aspect key flag + //! \param theModifierId the event modifier + static Standard_EXPORT Aspect_VKeyFlags keyFlag (const int theModifierId); + + //! Converts Qt button key to Aspect key mouse + //! \param theButtonId the event button + static Standard_EXPORT Aspect_VKeyMouse keyMouse (const int theButtonId);
Redundant Standard_EXPORT for private methods unused in header file.
Handle(AIS_Trihedron) myDefaultTrihedron; //!< NULL presentation until the first display + Handle(AIS_ViewCube) myViewCube; //!< NULL presentation until the first display
Please consider making description of these two fields more meaningful.
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Sep 10 06:41:26 2020 +0300
remarks correction
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Sep 10 06:41:26 2020 +0300
remarks correction
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Sep 10 06:46:26 2020 +0300
0031658: Inspector - using AIS_ViewController in View package
- View: using AIS_ViewController, AIS_ViewCube.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Sep 10 06:46:26 2020 +0300
0031658: Inspector - using AIS_ViewController in View package
- View: using AIS_ViewController, AIS_ViewCube.
Dear Kirill,
could you please review it again.
Jenkins job: http://jenkins-test-12.nnov.opencascade.com/view/CR31658-master-nds/
Thank for your help, Natalia
could you please review it again.
Jenkins job: http://jenkins-test-12.nnov.opencascade.com/view/CR31658-master-nds/
Thank for your help, Natalia
Please raise the patch
- OCCT branch: [archived branch]
- OCCT branch: [archived branch]
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17333.360000000142 / 17325.800000000123 [+0.04%]
Products
Total CPU difference: 12056.720000000096 / 12079.64000000011 [-0.19%]
Windows-64-VC14:
OCCT
Total CPU difference: 18817.921875 / 18792.46875 [+0.14%]
Products
Total CPU difference: 13294.09375 / 13274.75 [+0.15%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17333.360000000142 / 17325.800000000123 [+0.04%]
Products
Total CPU difference: 12056.720000000096 / 12079.64000000011 [-0.19%]
Windows-64-VC14:
OCCT
Total CPU difference: 18817.921875 / 18792.46875 [+0.14%]
Products
Total CPU difference: 13294.09375 / 13274.75 [+0.15%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]