Archived issue #0031709

Draw Harness - move methods ViewerTest::ParseOnOff()/ParseColor() to package Draw

Open CASCADEOCCT:DRAWclosed6 public notes

Search issues

Description

Parsing color and on/off arguments is a common task not specific to ViewerTest plugin, so that it is desired moving these methods to Draw package.

Steps to reproduce

N/A

Public activity

6 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Aug 12 15:58:22 2020 +0300

    0031709: Draw Harness - move methods ViewerTest::ParseOnOff()/ParseColor() to package Draw
    
    Methods ParseOnOff()/ParseColor() have been moved from package ViewerTest to Draw.
    Command "vlight -color" now accepts RGB values, not only name.
    Implementation of pload command has been cleaned up.
02Author
Patch is ready for review, branches CR31709 in OCCT and OCC Products.

Tested in scope of #0031713:
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31713-master-KGV/view/PRODUCTS%20compile/
03Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Commenter 4
The patch was reviewed
05Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17160.250000000116 / 17191.360000000128 [-0.18%]
Products
Total CPU difference: 11820.020000000079 / 11889.420000000087 [-0.58%]
Windows-64-VC14:
OCCT
Total CPU difference: 18724.890625 / 18788.5625 [-0.34%]
Products
Total CPU difference: 13316.109375 / 13265.75 [+0.38%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
06Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records