Archived issue #0031793

Draw Harness, vmanipulator - disable sorting picking result workaround

Open CASCADEOCCT:DRAWclosed6 public notes

Search issues

Description

AIS_Manipulator documentation suggests enabling AIS_InteractiveContext::SetPickClosest() for issue fixed long time ago by #0027797.

vmanipulator command still enables this workaround unconditionally, which doesn't look justified.
It is proposed removing a workaround in Draw command and updated test cases using manipulator (v3d/manipulator group first of all) - due to depth comparison differences, picked parts of manipulator slightly shift (it is expected that test cases will require a couple of pixels shift to reproduce exact same scenario).

Steps to reproduce

Not required

Public activity

6 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Sat Sep 26 21:47:58 2020 +0300

    0031793: Draw Harness, vmanipulator - disable sorting picking result workaround
    
    AIS_InteractiveContext::SetPickClosest() has been removed from vmanipulator command,
    and test cases using the manipulator have been updated.
02Commenter 3
03Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Author
Please raise the patch
- OCCT branch: [archived branch]

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31793-master-KGV/
05Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18085.050000000083 / 18057.60000000009 [+0.15%]
Products
Total CPU difference: 12174.620000000117 / 12124.200000000114 [+0.42%]
Windows-64-VC14:
OCCT
Total CPU difference: 19713.125 / 19772.65625 [-0.30%]
Products
Total CPU difference: 13533.8125 / 13527.921875 [+0.04%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
06Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records