Archived issue #0031842
Coding Rules, BOPAlgo - eliminate CLang warning -fsanitize=undefined reference binding to null pointer
Description
opencascade-7.5.0-beta/src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx:128:36: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx:128:36 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_4.cxx:220:38: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_4.cxx:220:38 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_5.cxx:281:38: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_5.cxx:281:38 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx:1076:41: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx:1076:41 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx:311:38: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx:311:38 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx:487:33: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx:487:33 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx:1022:28: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx:1022:28 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx:256:41: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx:256:41 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx:713:41: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx:713:41 in opencascade-7.5.0-beta/src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx:148:35: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx:148:35 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_Builder_2.cxx:453:30: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_Builder_2.cxx:453:30 in opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_Builder_3.cxx:435:30: runtime error: reference binding to null pointer of type 'const Message_ProgressScope' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior opencascade-7.5.0-beta/src/BOPAlgo/BOPAlgo_Builder_3.cxx:435:30 in
Steps to reproduce
Compile OCCT 7.5.0 Beta with -fsanitize=undefined and run solid boolean operations without providing a progress scope.
Public activity
6 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Mon Oct 12 18:00:22 2020 +0300
0031842: Coding Rules, BOPAlgo - eliminate CLang warning -fsanitize=undefined reference binding to null pointer
Added NULL checks before Progress Scope pointer dereference.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Mon Oct 12 18:00:22 2020 +0300
0031842: Coding Rules, BOPAlgo - eliminate CLang warning -fsanitize=undefined reference binding to null pointer
Added NULL checks before Progress Scope pointer dereference.
I grabbed the patch and this fix resolves the issue.
Patch is ready for review
- OCCT branch: [archived branch]
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31842-master-KGV/
- OCCT branch: [archived branch]
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31842-master-KGV/
For integration:
occt - CR31842
products - none
occt - CR31842
products - none
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18027.820000000127 / 18057.130000000117 [-0.16%]
Products
Total CPU difference: 12174.330000000093 / 12182.170000000115 [-0.06%]
Windows-64-VC14:
OCCT
Total CPU difference: 19740.03125 / 19746.828125 [-0.03%]
Products
Total CPU difference: 13564.71875 / 13586.625 [-0.16%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18027.820000000127 / 18057.130000000117 [-0.16%]
Products
Total CPU difference: 12174.330000000093 / 12182.170000000115 [-0.06%]
Windows-64-VC14:
OCCT
Total CPU difference: 19740.03125 / 19746.828125 [-0.03%]
Products
Total CPU difference: 13564.71875 / 13586.625 [-0.16%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records