DiscussionsIssue archiveOCCT:Foundation Classes

Archived issue #0031945

Foundation Classes - unique names of alerts of message report in DumpJson

Open CASCADEOCCT:Foundation Classesclosed9 public notes

Search issues

Description

It's proposed to dump alerts of Message_Report with incrementing index.
It lets avoid errors in parsing

Public activity

9 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Dec 16 11:34:59 2020 +0300

    0031945: Foundation Classes - unique names of alerts of message report in DumpJson
    
    - add OCCT_DUMP_FIELD_VALUE_NUMERICAL_INC and OCCT_DUMP_FIELD_VALUES_DUMPED_INC - to increment key Value;
    - add OCCT_DUMP_STREAM_VALUE_DUMPED - to give stream as a parameter of the DumpJson;
    - correct Message_Report, Message_CompositeAlerts to increment keys;
    - correct Message_AttributeMeter to have in result start and stop values united in value block: [start stop]. It's better for parsing;
    - correct result of Message::MetricToString output for updated in 29451 Message_MetricType enum;
    - correct Standard_Dump::AddValuesSeparator to avoid adding ',' in additional case;
    - correct Standard_Dump::FormatJson to add opening/closing brace for the whole result (for valid parsing);
    - correct Standard_Dump::FormatJson to ignore '\n' in value.
02Author
Dear Kirill,

could you please review.
Jenkis job is: http://jenkins-test-12.nnov.opencascade.com/view/CR31945-master-nds/

Thank you a lot for help, Natalia
03Commenter 3
+//! - OCCT_DUMP_FIELD_VALUE_NUMERICAL_INT. Use it for fields of numerical C++ types, like int, float, double.
+//!     It creates a pair "key_inc", "value",

Misprint in macros name.

+      for (int anIndent = 0; anIndent < anIndentCount; anIndent++)
+        aText += anIndentStr;

Please add brackets.
04Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
05Author
Done, please check.
06Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Dec 18 13:09:08 2020 +0300

    0031945: Foundation Classes - unique names of alerts of message report in DumpJson
    
    - add OCCT_DUMP_FIELD_VALUE_NUMERICAL_INC and OCCT_DUMP_FIELD_VALUES_DUMPED_INC - to increment key Value;
    - add OCCT_DUMP_STREAM_VALUE_DUMPED - to give stream as a parameter of the DumpJson;
    - correct Message_Report, Message_CompositeAlerts to increment keys;
    - correct Message_AttributeMeter to have in result start and stop values united in value block: [start stop]. It's better for parsing;
    - correct result of Message::MetricToString output for updated in 29451 Message_MetricType enum;
    - correct Standard_Dump::AddValuesSeparator to avoid adding ',' in additional case;
    - correct Standard_Dump::FormatJson to add opening/closing brace for the whole result (for valid parsing);
    - correct Standard_Dump::FormatJson to ignore '\n' in value.
07Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17709.570000000054 / 17744.450000000124 [-0.20%]
Products
Total CPU difference: 12258.480000000121 / 12330.210000000125 [-0.58%]
Windows-64-VC14:
OCCT
Total CPU difference: 19272.796875 / 19429.1875 [-0.80%]
Products
Total CPU difference: 13712.859375 / 13755.5 [-0.31%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
08Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
09Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records