Archived issue #0031958

Tests - testdiff shows empty Total Image difference

Open CASCADEOCCT:Testsclosed5 public notes

Search issues

Description

testdiff collects total image difference for image-only log, but not for cpu+memory+image log due to logical error.

Steps to reproduce

N/A

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Nov 25 15:18:01 2020 +0300

    0031958: Tests - testdiff shows empty Total Image difference
    
    stat(img1) counter is now incremented in case of total log.
    
    Renamed "Total Image difference" -> "Total IMAGE difference" for consistency with other output.
    
    Regexp inserting links to images now looks for "IMAGE ..." at the start of line
    to avoid misdetection on "Total IMAGE difference" line.
    _diff_show_positive_ratio() now prints image difference percents
    without leading empty space to highlight large deviations in RED.
    
    Image files having no match are now added to statistics as differences.
02Author
Patch is ready for review
- OCCT branch: [archived branch]

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31958-master-KGV/
03Commenter 3
The patch was reviewed
04Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18049.94000000008 / 18024.44000000013 [+0.14%]
Products
Total CPU difference: 12325.960000000132 / 12167.95000000011 [+1.30%]
Windows-64-VC14:
OCCT
Total CPU difference: 19703.46875 / 19697.21875 [+0.03%]
Products
Total CPU difference: 13792.6875 / 13647.203125 [+1.07%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
05Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records