DiscussionsIssue archiveOCCT:Application Framework

Archived issue #0031972

Application Framework, FSD_CmpFile - exception on reading file in old persistence format with Windows EOL

CommunityOCCT:Application Frameworkclosed6 public notes

Search issues

Description

Reading file with Windows EOLs by FSD_CmpFile lead to unhandled exception and reading failure since #0029344:
TCollection_AsciiString::SetValue(): NULL terminator is passed
 could not retrieve , Type not found or Unrecognized File Format
DDocStd_Open : Error

Steps to reproduce

N/A

Public activity

6 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Dec 2 14:28:38 2020 +0300

    0031972: Application Framework, FSD_CmpFile - exception on reading file in old persistence format with Windows EOL
    
    FSD_CmpFile::ReadLine()/FSD_CmpFile::ReadString() now use TCollection_AsciiString::Trunc()
    instead of ill-formed character assignment to '\0'.
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Author
Trivial patch is ready for review
- OCCT branch: [archived branch]

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31972-master-KGV
04Commenter 4
Reviewed
OCCT branch: [archived branch]
Products branch: [archived branch]
05Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18090.67999999998 / 18052.040000000085 [+0.21%]
Products
Total CPU difference: 12342.950000000128 / 12326.850000000131 [+0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 19751.5 / 19705.828125 [+0.23%]
Products
Total CPU difference: 13772.515625 / 13793.796875 [-0.15%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
06Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records