Archived issue #0031986
Visualization - Regression in StdPrs_WFDeflectionRestrictedFace::Add()
Description
See https://old.opencascade.com/content/stdprswfdeflectionrestrictedface-produces-overly-dense-sampling
Cylindrical face of a truncated cone returns a million points curve from the second Add() of StdPrs_WFDeflectionRestrictedFace
Cylindrical face of a truncated cone returns a million points curve from the second Add() of StdPrs_WFDeflectionRestrictedFace
Steps to reproduce
Additional information
I have fixed the problem. See the two lines marked with AAA in the attached file.
The problem was that the redundant line in the function, present in v6.9.1:
if ( Orient == TopAbs_FORWARD || Orient == TopAbs_REVERSED ) {
was deleted in v7.5.0 or earlier, but wrong closing curly bracket was deleted with that.
The problem was that the redundant line in the function, present in v6.9.1:
if ( Orient == TopAbs_FORWARD || Orient == TopAbs_REVERSED ) {
was deleted in v7.5.0 or earlier, but wrong closing curly bracket was deleted with that.
Public activity
6 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Mon Dec 7 13:39:07 2020 +0300
0031986: Visualization - Regression in StdPrs_WFDeflectionRestrictedFace::Add()
Fixed misplaced closing bracket after #0030146 fix.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Mon Dec 7 13:39:07 2020 +0300
0031986: Visualization - Regression in StdPrs_WFDeflectionRestrictedFace::Add()
Fixed misplaced closing bracket after #0030146 fix.
Author, thanks for analysis - it is caused by a fix for #0030146 (apparently, bracket was misplaced accidentally due to broken indentation / mixed tabulations in modified code).
Branch [archived branch] has been updated forcibly by Commenter 3.
[revision removed]
[revision removed]
Please raise the patch
- OCCT branch: [archived branch]
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31986-master-KGV/
- OCCT branch: [archived branch]
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31986-master-KGV/
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17756.510000000126 / 18090.92999999998 [-1.85%]
Products
Total CPU difference: 12330.210000000125 / 12342.950000000128 [-0.10%]
Windows-64-VC14:
OCCT
Total CPU difference: 19429.09375 / 19751.71875 [-1.63%]
Products
Total CPU difference: 13755.5 / 13772.515625 [-0.12%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17756.510000000126 / 18090.92999999998 [-1.85%]
Products
Total CPU difference: 12330.210000000125 / 12342.950000000128 [-0.10%]
Windows-64-VC14:
OCCT
Total CPU difference: 19429.09375 / 19751.71875 [-1.63%]
Products
Total CPU difference: 13755.5 / 13772.515625 [-0.12%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records