Archived issue #0032037

Visualization - move V3d_View::FitMinMax() to Graphic3d_Camera::FitMinMax()

Open CASCADEOCCT:Visualizationclosed3 public notes

Description

V3d_View::FitMinMax() is currently an internal method adjusting camera, but it could be useful also outside of V3d_View.

It is proposed moving implementation to Graphic3d_Camera::FitMinMax(), which will be consistent with another Graphic3d_Camera::ZFitAll() method.

Steps to reproduce

N/A

Public activity

3 archived notes

Participants are labeled by their role within this record.

01Commenter 22021-01-09 23:33

Branch [archived branch] has been created by Author.

[revision removed]

Detailed log of new commits:

Author: Author
Date: Mon Jan 4 11:53:24 2021 +0300

0032037: Visualization - move V3d_View::FitMinMax() to Graphic3d_Camera::FitMinMax()

02Author2021-01-10 02:05

Please raise the patch
- OCCT branch: [archived branch]

03Commenter 12021-01-16 13:29

Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17754.160000000134 / 17720.07000000011 [+0.19%]
Products
Total CPU difference: 12412.630000000105 / 12419.360000000095 [-0.05%]
Windows-64-VC14:
OCCT
Total CPU difference: 19336.3125 / 19330.015625 [+0.03%]
Products
Total CPU difference: 13740.03125 / 13831.828125 [-0.66%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention