DiscussionsIssue archiveOCCT:Visualization

Archived issue #0032045

Visualization, TKOpenGl - move light source functions from OpenGl_ShaderManager.cxx to Shaders

Open CASCADEOCCT:Visualizationclosed5 public notes

Search issues

Description

It is desired moving out light source GLSL functions from OpenGl_ShaderManager.cxx to Shaders.

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Sun Jan 10 01:43:03 2021 +0300

    0032045: Visualization, TKOpenGl - move light source functions from OpenGl_ShaderManager.cxx to Shaders

Author: Author
Date: Sun Jan 3 03:05:32 2021 +0300

    0032036: Visualization, TKOpenGl - broken Cubemap background on GeForce 320M
    
    Enable GL_DEPTH_CLAMP while rendering skybox to workaround unexpected clamping issue on some GPUs.
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Author
Patch is ready for review
- OCCT branch: [archived branch]

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32045-master-KGV/
04Commenter 4
The patch was reviewed without remarks
05Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17754.160000000134 / 17720.07000000011 [+0.19%]
Products
Total CPU difference: 12412.630000000105 / 12419.360000000095 [-0.05%]
Windows-64-VC14:
OCCT
Total CPU difference: 19336.3125 / 19330.015625 [+0.03%]
Products
Total CPU difference: 13740.03125 / 13831.828125 [-0.66%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention