Archived issue #0032121

Draw Harness, ViewerTest - implement -reset option for vlight command

Open CASCADEOCCT:DRAWclosed10 public notes

Search issues

Description

It is proposed extended vlight command with -reset argument which will replace light source with specified index with newly created one.
If replaced light source was already displayed - the new once should be displayed instead.

Steps to reproduce

pload MODELING VISUALIZATION
vclear
vinit View1 -width 1280 -height 720
vlight -clear
vbackground -color GRAY
vrenderparams -shadingModel PBR
box b 10 10 10 30 30 30
vdisplay b -dispMode 1
vaspects b -material Brass
vfit

vlight light1   -type positional -pos 25 25 50 -intensity 10000000000 -range 20 -color BLUE -display
vlight light1   -reset
vlight amblight -type ambient -color WHITE -display
vlight spot     -type spotlight -pos 50 25 25 -dir -1 0 0 -intensity 1000000000 -color RED -display
vlight dirlight -type directional -dir 0 1 0 -color GREEN -display
vlight

Public activity

10 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Tue Feb 9 18:01:53 2021 +0300

    0032121: Draw Harness, ViewerTest - implement -set option for vlight command
    
    - Extended vlight command with -set/-replace argument
02Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Tue Feb 9 18:01:53 2021 +0300

    0032121: Draw Harness, ViewerTest - implement -set option for vlight command
    
    vlight command has been revised to make it more friendly.
    Added arguments -enable/-disable for managing enabled state.
    vlight command now accepts light index or name as first argument.
    Added -set/-replace argument.
    
    V3d_Viewer::SetDefaultLights() now sets names "headlight" and "ambient" to created lights.
    Draw::Atof(), applied corrections to avoid explicit new/delete calls.
03Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Jul 9 23:22:29 2021 +0300

    0032121: Draw Harness, ViewerTest - implement -reset option for vlight command
    
    vlight command has been revised to provide more friendly syntax.
    Command now accepts light index or name as first argument.
    Added arguments -enable/-disable for managing enabled state.
    Added argument -reset to reset light parameters to default values.
    
    V3d_Viewer::SetDefaultLights() now sets names "headlight" and "ambient" to created lights.
    Graphic3d_TypeOfLightSource enumeration values have been renamed to avoid shortcuts.
    Draw::Atof(), applied corrections to avoid explicit new/delete calls.
04Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
05Author
06Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
07Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17229.290000000303 / 17544.51000000034 [-1.80%]
Products
Total CPU difference: 11476.020000000117 / 11490.74000000011 [-0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 19019.8125 / 19318.21875 [-1.54%]
Products
Total CPU difference: 12732.515625 / 12831.40625 [-0.77%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
08Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
09Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
10Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records