Modeling Data - Restriction of access to internal arrays for Poly_Triangulation, revision of API

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Feb 16 14:24:15 2021 +0300

    0032133: Modeling Data - Restriction of access to internal arrays for Poly_Triangulation, revision of API
    
    // Removed methods from Poly_Triangulation and Poly_PolygonOnTriangulation giving access to internal arrays of 2d and 3d nodes, triangles and normals.

-  Standard_Integer NbNodes() const { return myNodes.Length(); }
+  Standard_Integer NbNodes() const {
+    return myNodes.Size();
+  }

Please avoid unrelated changes.

+  Standard_Boolean          myHasUVNodes;

This flag looks redundant - !NCollection_Array1::IsEmpty() could be used instead.

+typedef NCollection_Vec3 <Standard_ShortReal> Vec3f;

This typedef contradicts OCCT Coding Style - please define a fully-qualified type name like gp_Vec3f or Poly_Vec3f within a dedicated header.

Please proceed with remarks.

Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Feb 16 18:22:19 2021 +0300

    0032133: Modeling Data - Restriction of access to internal arrays for Poly_Triangulation, revision of API
    
    // Fixed remarks:
    // - myHasUVNodes is replaced by !myUVNodes.IsEmpty()
    // - Poly_Vec3f is introduced.

Branch [archived branch] has been created by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Feb 16 14:24:15 2021 +0300

    0032133: Modeling Data - Restriction of access to internal arrays for Poly_Triangulation, revision of API
    
    Removed methods from Poly_Triangulation/Poly_PolygonOnTriangulation giving access to internal arrays of 2d and 3d nodes, triangles and normals.

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

Please raise the patch
- OCCT: branch CR32133_1;
- OCC Products: branch CR32133_1.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32133_1-CR32133_1-KGV/

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17876.110000000237 / 17806.660000000233 [+0.39%]
Products
Total CPU difference: 11541.23000000011 / 11513.250000000124 [+0.24%]
Windows-64-VC14:
OCCT
Total CPU difference: 19352.0 / 19376.859375 [-0.13%]
Products
Total CPU difference: 12836.421875 / 12857.265625 [-0.16%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]