Archived issue #0032201

Visualization, TKOpenGl - unify Phong/PBR material properties getters

Open CASCADEOCCT:Visualizationclosed6 public notes

Description

Declarations.glsl declares material accessors as separate front/back getters for Common definition (occFrontMaterial_Diffuse/occBackMaterial_Diffuse)
and as unified getter taking Boolean flag for PBR properties (like occPBRMaterial_Color(in bool theIsFront)).

It is proposed following a common approach.

Steps to reproduce

N/A

Public activity

6 archived notes

Participants are labeled by their role within this record.

01Commenter 22021-03-06 03:23

Branch [archived branch] has been created by Author.

[revision removed]

No new revisions were added by this update.

02Author2021-03-06 10:03

Patch is ready for review
- OCCT: branch CR32201.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32201-master-KGV/

03Commenter 22021-03-06 14:35

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

04Commenter 42021-03-17 14:01

The patch was reviewed

05Commenter 12021-03-20 12:49

Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17753.85000000016 / 17750.250000000156 [+0.02%]
Products
Total CPU difference: 11481.660000000102 / 11540.5800000001 [-0.51%]
Windows-64-VC14:
OCCT
Total CPU difference: 19361.09375 / 19341.28125 [+0.10%]
Products
Total CPU difference: 12879.75 / 12869.921875 [+0.08%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

06Commenter 22021-04-03 12:50

Branch [archived branch] has been deleted by Participant.

[revision removed]