DiscussionsIssue archiveOCCT:Visualization

Archived issue #0032202

Visualization - XCAFDoc_VisMaterial::FillMaterialAspect() should copy emissive color from PBR definition

Open CASCADEOCCT:Visualizationclosed7 public notes

Search issues

Description

XCAFDoc_VisMaterial::FillMaterialAspect() should propagate emission coefficients between PBR / Common materials as they have the same meaning.

Steps to reproduce

test de_mesh gltf_read lantert

Public activity

7 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Sat Mar 6 10:48:18 2021 +0300

    0032202: Visualization - XCAFDoc_VisMaterial::FillMaterialAspect() should copy emissive color from PBR definition
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Author
Patch is ready for review
- OCCT: branch CR32202.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32202-master-KGV/
05Commenter 5
The patch was reviewed
06Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17753.85000000016 / 17750.250000000156 [+0.02%]
Products
Total CPU difference: 11481.660000000102 / 11540.5800000001 [-0.51%]
Windows-64-VC14:
OCCT
Total CPU difference: 19361.09375 / 19341.28125 [+0.10%]
Products
Total CPU difference: 12879.75 / 12869.921875 [+0.08%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
07Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records