DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0032236

Modeling Algorithms - Exception on calculation optimal bounding box

CommunityOCCT:Modeling Algorithmsclosed19 public notes

Search issues

Description

OCC throw exception on calculation optimal bounding box for the shape with all degenerated edges.

Such surface can be obtained from GeomPlate_BuildPlateSurface with following parameters:
Points: {0, 0, 0}, {0, 0, 1}, {0, 1, 1}
Tolerance: 20


It is not possible to set tolerance for gplate in DRAW
So I stored it and attached in Attachment 1 (BREP)

Steps to reproduce

restore Attachment 1 (BREP) aaa
bounding -optimal aaa

Public activity

19 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Commenter 2.

[revision removed]


Detailed log of new commits:

Author: Commenter 2
Date: Wed Mar 24 10:37:29 2021 +0300

    0032236: Modeling Algorithms - Exception on calculation optimal bounding box
    
    BRepBndLib - added VOID box checks to AdjustFaceBox() method.
02Commenter 2
Naive patch adding IsVoid() checks have been pushed to CR32236, though I'm not sure that assigning Edge box to Face box is correct (don't get the overall idea of this AdjustFaceBox()).

03Commenter 3
Now if both FaceBox and EdgeBox are void the next possible exception can be at line 310:
  aLocBox.Get(xmin, ymin, zmin, xmax, ymax, zmax);
It is worth to protect it like it is done at line 367:
  if (!aLocBox.IsVoid())
04Commenter 1
Branch [archived branch] has been updated forcibly by Commenter 2.

[revision removed]
05Commenter 2
> It is worth to protect it like it is done at line 367:
Added.
06Commenter 1
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: Commenter 2
Date: Wed Mar 24 10:37:29 2021 +0300

    0032236: Modeling Algorithms - Exception on calculation optimal bounding box
    
     - BRepBndLib - added VOID box checks to AdjustFaceBox() method.
     - added the test
07Commenter 1
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Thu Sep 16 08:53:25 2021 +0300

    fix test

08Commenter 1
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: Commenter 2
Date: Wed Mar 24 10:37:29 2021 +0300

    0032236: Modeling Algorithms - Exception on calculation optimal bounding box
    
     - BRepBndLib - added VOID box checks to AdjustFaceBox() method.
     - added the test
09Commenter 1
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Thu Sep 16 10:18:59 2021 +0300

    fix test

10Commenter 1
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Thu Sep 16 11:40:38 2021 +0300

    fix test

11Commenter 1
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Thu Sep 16 14:06:12 2021 +0300

    fix test

12Commenter 1
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: Commenter 2
Date: Wed Mar 24 10:37:29 2021 +0300

    0032236: Modeling Algorithms - Exception on calculation optimal bounding box
    
     - BRepBndLib - added VOID box checks to AdjustFaceBox() method.
     - added the test
13Commenter 3
Patch is ready for review:
- OCC Products: branch CR32236_3.

Tests are successfully: http://jenkins-test-occt/view/CR32236-master-Commenter 3/view/ALL/
14Commenter 14
For integration:
occt - CR32236_3
products - none
15Commenter 4
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17390.540000000547 / 17358.370000000414 [+0.19%]
Products
Total CPU difference: 11364.740000000118 / 11411.36000000011 [-0.41%]
Windows-64-VC14:
OCCT
Total CPU difference: 19321.5625 / 19327.15625 [-0.03%]
Products
Total CPU difference: 12746.171875 / 12747.78125 [-0.01%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
16Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]
17Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]
18Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]
19Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]