Archived issue #0032285

Coding Rules - get rid of generic methods in GCPnts_TangentialDeflection

Open CASCADEOCCT:Codingclosed11 public notes

Search issues

Description

GCPnts_TangentialDeflection is implemented using generic methods in GCPnts_TangentialDeflection.pxx.
It is proposed replacing generic methods via C++ templates.

Steps to reproduce

N/A

Public activity

11 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Apr 6 15:16:22 2021 +0300

    0032285: Coding Rules - get rid of generic methods in GCPnts_TangentialDeflection
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Author
Patch is ready for review
- OCCT: branch CR32285.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32285-master-KGV/
04Commenter 4
Break long lines in GCPnts_TangentialDeflection.hxx.

+ //! On respecte ll'angle et la fleche, on peut imposer un nombre minimum de points sur un element lineaire.

Use english:
Respecting the angle and the deflection, we impose a minimum number of points on a curve.

05Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Apr 7 12:15:46 2021 +0300

    # remarks (cosmetics)

06Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Apr 6 15:16:22 2021 +0300

    0032285: Coding Rules - get rid of generic methods in GCPnts_TangentialDeflection
07Author
Remarks have been pushed.
08Commenter 8
For integration:
occt - CR32285_1
products - none
09Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18019.250000000382 / 18057.390000000454 [-0.21%]
Products
Total CPU difference: 11542.82000000007 / 11506.800000000105 [+0.31%]
Windows-64-VC14:
OCCT
Total CPU difference: 19509.84375 / 19513.828125 [-0.02%]
Products
Total CPU difference: 12890.46875 / 12943.234375 [-0.41%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
10Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
11Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records