Archived issue #0032328
Missing include of TopoDS_Edge.hxx in ShapeUpgrade_UnifySameDomain.hxx
Description
When using ShapeUpgrade_UnifySameDomain.hxx in client code without having included TopoDS_Edge.hxx results into a build failure because in commit https://git.dev.opencascade.org/gitweb/?p=occt.git;a=commitdiff;h=[revision removed];hp=[revision removed] a new struct below has been added:
[code]
struct SubSequenceOfEdges
{
TopTools_SequenceOfShape SeqsEdges;
TopoDS_Edge UnionEdges;
};
[/code]
This happens with the recently released version 7.5.2 (which is not yet offered in the list of product versions)
[code]
struct SubSequenceOfEdges
{
TopTools_SequenceOfShape SeqsEdges;
TopoDS_Edge UnionEdges;
};
[/code]
This happens with the recently released version 7.5.2 (which is not yet offered in the list of product versions)
Public activity
11 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Mon Sep 6 10:36:38 2021 +0300
0032328: Missing include of TopoDS_Edge.hxx in ShapeUpgrade_UnifySameDomain.hxx
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Mon Sep 6 10:36:38 2021 +0300
0032328: Missing include of TopoDS_Edge.hxx in ShapeUpgrade_UnifySameDomain.hxx
Branch [archived branch] has been updated forcibly by Commenter 3.
[revision removed]
[revision removed]
Patch is ready for review
- OCCT: branch CR32328.
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32328-master-KGV/view/OCCT%20compile/
- OCCT: branch CR32328.
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32328-master-KGV/view/OCCT%20compile/
Why the static function GenerateSubSeq is made a class method? There are many static functions in this cxx file, and why this one is an exception?
Because it takes "SubSequenceOfEdges" as argument, and making SubSequenceOfEdges a globally defined structure as before is prohibited by coding style.
Why not to define SubSequenceOfEdges in unnamed namespace, as we do with static functions?
For integration:
occt - CR32328
products - none
occt - CR32328
products - none
Branch [archived branch] has been created by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Wed Sep 8 12:58:20 2021 +0300
# test stack trace
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Wed Sep 8 12:58:20 2021 +0300
# test stack trace
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17358.54000000042 / 17496.500000000422 [-0.79%]
Products
Total CPU difference: 11397.800000000112 / 11567.680000000111 [-1.47%]
Windows-64-VC14:
OCCT
Total CPU difference: 19328.109375 / 19307.609375 [+0.11%]
Products
Total CPU difference: 12733.328125 / 12920.953125 [-1.45%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17358.54000000042 / 17496.500000000422 [-0.79%]
Products
Total CPU difference: 11397.800000000112 / 11567.680000000111 [-1.47%]
Windows-64-VC14:
OCCT
Total CPU difference: 19328.109375 / 19307.609375 [+0.11%]
Products
Total CPU difference: 12733.328125 / 12920.953125 [-1.45%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]