DiscussionsIssue archiveOCCT:Visualization

Archived issue #0032349

Visualization, TKOpenGl - move base buffer interface out from OpenGl_VertexBuffer class to OpenGl_Buffer

Open CASCADEOCCT:Visualizationclosed10 public notes

Search issues

Description

OpenGl_VertexBuffer class inheritance is misleading - not all buffer objects serve as vertex buffers.

Steps to reproduce

N/A

Public activity

10 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu May 6 20:03:24 2021 +0300

    0032349: Visualization, TKOpenGl - move base buffer interface out from OpenGl_VertexBuffer class to OpenGl_Buffer
    
    OpenGl_FrameBuffer - added initializers taking vec2i instead of (int,int) for dimensions.
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
05Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
06Author
Patch is ready for review
- OCCT: branch CR32349;
- OCC Products: branch CR32349.

http://jenkins-test-occt.nnov.opencascade.com/view/CR32349-CR32349-KGV/view/COMPARE/
07Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
08Commenter 8
The patch was reviewed
09Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17874.080000000333 / 17899.800000000352 [-0.14%]
Products
Total CPU difference: 11557.880000000083 / 11563.54000000011 [-0.05%]
Windows-64-VC14:
OCCT
Total CPU difference: 19394.921875 / 19369.625 [+0.13%]
Products
Total CPU difference: 12880.234375 / 12896.03125 [-0.12%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
10Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]