DiscussionsIssue archiveOCCT:Visualization

Archived issue #0032390

Visualization, SelectMgr_FrustumBuilder - use camera instead of duplicated methods

Open CASCADEOCCT:Visualizationclosed16 public notes

Search issues

Description

Store handle to camera as field of SelectMgr_FrustumBuilder instead of duplicated camera parameters.
Use all required methods (ProjectPntOnViewPlane/unProject/safePointCast) from camera and avoid code duplication.

Steps to reproduce

Not required

Public activity

16 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri May 28 17:25:04 2021 +0300

    0032390: Visualization, SelectMgr_FrustumBuilder - use camera instead of duplicated methods
02Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri May 28 17:25:04 2021 +0300

    0032390: Visualization, SelectMgr_FrustumBuilder - use camera instead of duplicated methods
    
    Add method Graphic3d_Camera::SetIdentityOrientation() to set camera parameters to make current orientation matrix identity one
    Remove all matrices from selection intersectors and frustum builder and use camera instead of them
03Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri May 28 17:25:04 2021 +0300

    0032390: Visualization, SelectMgr_FrustumBuilder - use camera instead of duplicated methods
    
    Add method Graphic3d_Camera::SetIdentityOrientation() to set camera parameters to make current orientation matrix identity one
    Remove all matrices from selection intersectors and frustum builder and use camera instead of them
04Commenter 6
05Commenter 1
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
06Commenter 1
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Jun 21 16:08:06 2021 +0300

    #kgv remarks

07Commenter 1
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Jun 21 19:43:27 2021 +0300

    #fix A1 axis test of vselect package

08Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri May 28 17:25:04 2021 +0300

    0032390: Visualization, SelectMgr_FrustumBuilder - use camera instead of duplicated methods
    
    Add method Graphic3d_Camera::SetIdentityOrientation() to set camera parameters to make current orientation matrix identity one
    Remove all matrices from selection intersectors and frustum builder and use camera instead of them
09Commenter 11
10Commenter 12
The patch CR32390_3 is ready for review
11Commenter 1
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
12Commenter 2
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17457.040000000452 / 17401.81000000044 [+0.32%]
Products
Total CPU difference: 11511.540000000101 / 11508.180000000091 [+0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19236.53125 / 19191.4375 [+0.23%]
Products
Total CPU difference: 12832.328125 / 12883.6875 [-0.40%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
13Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]
14Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]
15Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]
16Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]