Archived issue #0032417
Coding Rules - clean up public headers gp_Mat.hxx/ gp_Mat2d.hxx from internal macros
Description
gp_Mat.hxx/ gp_Mat2d.hxx headers define auxiliary macros for more compact definition of matrix operations:
It is proposed reconsidering implementation to avoid using macros when possible.
#define Mat00 matrix[0][0] #define Mat01 matrix[0][1] ...
It is proposed reconsidering implementation to avoid using macros when possible.
Steps to reproduce
N/A
Public activity
11 archived notes
Participants are labeled by their role within this record.
Solution evaluation
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Fri Jun 4 11:13:47 2021 +0300
0032417: Coding Rules - clean up public headers gp_Mat.hxx/ gp_Mat2d.hxx from internal macros
- deleted internal macros
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Fri Jun 4 11:13:47 2021 +0300
0032417: Coding Rules - clean up public headers gp_Mat.hxx/ gp_Mat2d.hxx from internal macros
- deleted internal macros
Patches are ready to review:
- OCCT: CR32417
- OCCT Products: CR32417
- OCCT: CR32417
- OCCT Products: CR32417
Testing
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Fri Jun 4 11:13:47 2021 +0300
0032417: Coding Rules - clean up public headers gp_Mat.hxx/ gp_Mat2d.hxx from internal macros
Deleted internal macros.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Fri Jun 4 11:13:47 2021 +0300
0032417: Coding Rules - clean up public headers gp_Mat.hxx/ gp_Mat2d.hxx from internal macros
Deleted internal macros.
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Please raise the patch
- OCCT: branch CR32417_1;
- OCC Products: none.
- OCCT: branch CR32417_1;
- OCC Products: none.
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17450.34000000035 / 17504.380000000427 [-0.31%]
Products
Total CPU difference: 11477.360000000128 / 11532.860000000106 [-0.48%]
Windows-64-VC14:
OCCT
Total CPU difference: 19191.5625 / 19141.46875 [+0.26%]
Products
Total CPU difference: 12904.59375 / 12831.25 [+0.57%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17450.34000000035 / 17504.380000000427 [-0.31%]
Products
Total CPU difference: 11477.360000000128 / 11532.860000000106 [-0.48%]
Windows-64-VC14:
OCCT
Total CPU difference: 19191.5625 / 19141.46875 [+0.26%]
Products
Total CPU difference: 12904.59375 / 12831.25 [+0.57%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records