Archived issue #0032441
Draw Harness - command readstl doesn't print error message on failure
Description
Passing an invalid file path to readstl command doesn't produce any error message.
Steps to reproduce
pload MODELING XDE VISUALIZATION
readstl s {c:/work/downloads/AAA.stl}
# KO - no error message
trinfo s
Public activity
13 archived notes
Participants are labeled by their role within this record.
Analysis, Solution Implementation
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed Jun 23 17:08:56 2021 +0300
0032441: Draw Harness - command readstl doesn't print error message on failure
- added producing error message when passing an invalid file path
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed Jun 23 17:08:56 2021 +0300
0032441: Draw Harness - command readstl doesn't print error message on failure
- added producing error message when passing an invalid file path
Solution Implementation, Testing
Patch is ready to review:
- OCCT: CR32441
- OCCT: CR32441
Please generate message within RWStl_Reader::Read() instead of Draw command.
The message is confusing.
Something like this would be more describable:
> Message::SendFail (TCollection_AsciiString ("Error: file '") + theFile + "' is not found");
+ Message::SendFail() << "Error: document with name " << aFilePath << " does not exist";
The message is confusing.
Something like this would be more describable:
> Message::SendFail (TCollection_AsciiString ("Error: file '") + theFile + "' is not found");
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Tue Jun 29 14:43:36 2021 +0300
# kgv remarks
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Tue Jun 29 14:43:36 2021 +0300
# kgv remarks
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed Jun 23 17:08:56 2021 +0300
0032441: Draw Harness - command readstl doesn't print error message on failure
- added producing error message when passing an invalid file path
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed Jun 23 17:08:56 2021 +0300
0032441: Draw Harness - command readstl doesn't print error message on failure
- added producing error message when passing an invalid file path
Solution Implementation, Testing
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17426.490000000336 / 17457.450000000455 [-0.18%]
Products
Total CPU difference: 11521.170000000124 / 11511.540000000101 [+0.08%]
Windows-64-VC14:
OCCT
Total CPU difference: 19263.921875 / 19236.96875 [+0.14%]
Products
Total CPU difference: 12854.34375 / 12832.328125 [+0.17%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17426.490000000336 / 17457.450000000455 [-0.18%]
Products
Total CPU difference: 11521.170000000124 / 11511.540000000101 [+0.08%]
Windows-64-VC14:
OCCT
Total CPU difference: 19263.921875 / 19236.96875 [+0.14%]
Products
Total CPU difference: 12854.34375 / 12832.328125 [+0.17%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records