Archived issue #0032487
Visualization - synchronize myHasEntityWithPersistence with such entities number
Description
Offer of 27919:
"Maybe replacing myHasEntityWithPersistence with a counter?"
Replace boolean value myHasEntityWithPersistence of SelectMgr_SensitiveEntitySet on integer. It should be incremented when new entity is added and decremented when it's removed.
"Maybe replacing myHasEntityWithPersistence with a counter?"
Replace boolean value myHasEntityWithPersistence of SelectMgr_SensitiveEntitySet on integer. It should be incremented when new entity is added and decremented when it's removed.
Steps to reproduce
v3d/dimensions/bug27919
Public activity
14 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: drochalo
Date: Thu Oct 26 11:43:19 2023 +0100
0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
Changed myHasEntityWithPersistence to a counter.
Modified logical test in SelectMgr_ViewerSelector::traverseObject.
[revision removed]
Detailed log of new commits:
Author: drochalo
Date: Thu Oct 26 11:43:19 2023 +0100
0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
Changed myHasEntityWithPersistence to a counter.
Modified logical test in SelectMgr_ViewerSelector::traverseObject.
Dear Marina, please review.
Tests on jenkins: http://jenkins-test-10.nnov.opencascade.com/view/CR32487-master-drochalo/view/COMPARE/
Tests on jenkins: http://jenkins-test-10.nnov.opencascade.com/view/CR32487-master-drochalo/view/COMPARE/
Standard_Integer HasEntityWithPersistence() const { return myHasEntityWithPersistence; }
Please change to
Standard_Boolean HasEntityWithPersistence() const { return myNbEntityWithPersistence > 0; }
Standard_Integer myHasEntityWithPersistence;
Please rename => myNbEntityWithPersistence
Please change to
Standard_Boolean HasEntityWithPersistence() const { return myNbEntityWithPersistence > 0; }
Standard_Integer myHasEntityWithPersistence;
Please rename => myNbEntityWithPersistence
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: drochalo
Date: Fri Oct 27 16:19:21 2023 +0100
0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
Renamed variable to myNbEntityWithPersistence.
Modified HasEntityWithPersistence() method.
[revision removed]
Detailed log of new commits:
Author: drochalo
Date: Fri Oct 27 16:19:21 2023 +0100
0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
Renamed variable to myNbEntityWithPersistence.
Modified HasEntityWithPersistence() method.
Dear Marina,
the requested changes were made.
New tests were performed in Jenkins and apart from a test that fails but that does not appear to have a connection to the changes made, everything else looks fine.
Jenkins test: http://jenkins-test-10.nnov.opencascade.com/view/CR32487-master-drochalo/view/COMPARE/
the requested changes were made.
New tests were performed in Jenkins and apart from a test that fails but that does not appear to have a connection to the changes made, everything else looks fine.
Jenkins test: http://jenkins-test-10.nnov.opencascade.com/view/CR32487-master-drochalo/view/COMPARE/
Please remove extra brackets
Please remove extra spaces.
Standard_Boolean HasEntityWithPersistence() const { return (myNbEntityWithPersistence > 0); }
Please remove extra spaces.
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: drochalo
Date: Mon Nov 20 11:11:09 2023 +0000
0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
Code cleanup.
Author: drochalo
Date: Mon Nov 20 10:48:22 2023 +0000
Merge branch 'master' of git.dev.opencascade.org:occt into CR32487
[revision removed]
Detailed log of new commits:
Author: drochalo
Date: Mon Nov 20 11:11:09 2023 +0000
0032487: Visualization - synchronize myHasEntityWithPersistence with such entities number
Code cleanup.
Author: drochalo
Date: Mon Nov 20 10:48:22 2023 +0000
Merge branch 'master' of git.dev.opencascade.org:occt into CR32487
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: drochalo
Date: Mon Dec 18 09:57:04 2023 +0000
Merge branch 'master' of git.dev.opencascade.org:occt into CR32487
[revision removed]
Detailed log of new commits:
Author: drochalo
Date: Mon Dec 18 09:57:04 2023 +0000
Merge branch 'master' of git.dev.opencascade.org:occt into CR32487
Dear Marina,
please review.
New tests were done and failed tests are not connected to the changes made:
http://jenkins-test-10.nnov.opencascade.com/view/CR32487-master-drochalo/view/COMPARE/
please review.
New tests were done and failed tests are not connected to the changes made:
http://jenkins-test-10.nnov.opencascade.com/view/CR32487-master-drochalo/view/COMPARE/
Please remove extra spaces and lines
And use rebase instead merge to rebase you branch on current master
And use rebase instead merge to rebase you branch on current master
Attachment 1 (PNG) (43,195 bytes)
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 18633.43999999986 / 18269.079999999904 [+1.99%]
Products
Total CPU difference: 11763.979999999934 / 11554.499999999949 [+1.81%]
Windows-64-VC142:
OCCT
Total CPU difference: 20136.3125 / 20132.90625 [+0.02%]
Products
Total CPU difference: 13131.234375 / 12359.828125 [+6.24%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 18633.43999999986 / 18269.079999999904 [+1.99%]
Products
Total CPU difference: 11763.979999999934 / 11554.499999999949 [+1.81%]
Windows-64-VC142:
OCCT
Total CPU difference: 20136.3125 / 20132.90625 [+0.02%]
Products
Total CPU difference: 13131.234375 / 12359.828125 [+6.24%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Commenter 4.
[revision removed]
[revision removed]
Related records