Archived issue #0032546
Data Exchange, XCAF - mark material as defined XCAFDoc_VisMaterialPBR::IsDefined=true within default constructor
Description
Currently XCAFDoc_VisMaterialPBR and XCAFDoc_VisMaterialCommon constructors create a material as undefined, so that user has to set XCAFDoc_VisMaterialPBR::IsDefined=true explicitly to ensure it being actually used.
This might be confusing and easy to oversee. It is proposed changed default to TRUE and setting material as undefined explicitly within XCAFDoc_VisMaterial constructor and similar context, where these materials are expected to be undefined by default.
This might be confusing and easy to oversee. It is proposed changed default to TRUE and setting material as undefined explicitly within XCAFDoc_VisMaterial constructor and similar context, where these materials are expected to be undefined by default.
Public activity
5 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 30 20:53:33 2021 +0300
0032546: Data Exchange, XCAF - mark material as defined XCAFDoc_VisMaterialPBR::IsDefined=true within default constructor
XCAFDoc_VisMaterialCommon and XCAFDoc_VisMaterialPBR default constructors now set IsDefined property to TRUE.
So that it is required to set IsDefined=false explicitly to create an undefined material,
which is done by XCAFDoc_VisMaterial constructor.
Existing application code shouldn't require any modifications in most cases
(IsDefined=true required before to setup material could be now removed).
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Aug 30 20:53:33 2021 +0300
0032546: Data Exchange, XCAF - mark material as defined XCAFDoc_VisMaterialPBR::IsDefined=true within default constructor
XCAFDoc_VisMaterialCommon and XCAFDoc_VisMaterialPBR default constructors now set IsDefined property to TRUE.
So that it is required to set IsDefined=false explicitly to create an undefined material,
which is done by XCAFDoc_VisMaterial constructor.
Existing application code shouldn't require any modifications in most cases
(IsDefined=true required before to setup material could be now removed).
Patch is ready for review
- OCCT: branch CR32546.
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32546-master-KGV/
- OCCT: branch CR32546.
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32546-master-KGV/
The patch was reviewed
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17495.94000000042 / 17441.55000000031 [+0.31%]
Products
Total CPU difference: 11565.440000000113 / 11534.270000000102 [+0.27%]
Windows-64-VC14:
OCCT
Total CPU difference: 19307.140625 / 19200.421875 [+0.56%]
Products
Total CPU difference: 12917.859375 / 12874.53125 [+0.34%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17495.94000000042 / 17441.55000000031 [+0.31%]
Products
Total CPU difference: 11565.440000000113 / 11534.270000000102 [+0.27%]
Windows-64-VC14:
OCCT
Total CPU difference: 19307.140625 / 19200.421875 [+0.56%]
Products
Total CPU difference: 12917.859375 / 12874.53125 [+0.34%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]
Related records