DiscussionsIssue archiveOCCT:Visualization

Archived issue #0032547

Visualization, Select3D_SensitiveCylinder - implement picking of a hollow cylinder

Open CASCADEOCCT:Visualizationclosed22 public notes

Search issues

Description

#0032281 introduced Select3D_SensitiveCylinder for picking a solid cylinder.
However, in many cases it is desired picking a hollow cylinder and cylinder circular boundaries independently - in case of subshape decomposition or just in case of a hollow pipe definition (or maybe a pipe with addition thickness).

Steps to reproduce

pload MODELING VISUALIZATION
pcylinder cyl 10 20
explode cyl F
vclear
vdisplay cyl_1 -dispmode 1
# KO - entities are not Select3D_SensitiveCylinder 

vclear
vdisplay cyl -dispmode 1
vselmode cyl FACES 1
# KO - entities are not Select3D_SensitiveCylinder 

Public activity

22 archived notes

Participants are labeled by their role within this record.

01Commenter 3
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: sshutina
Date: Mon Jan 24 10:16:50 2022 +0300

    0032547: Visualization, Select3D_SensitiveCylinder - implement picking of a hollow cylinder
    
     - cylinder overlap divided into 2 steps : intersection with cylinder disks and intersection with hollow cylinder
02Commenter 3
Branch [archived branch] has been created by Commenter 1.

[revision removed]


Detailed log of new commits:

Author: Commenter 1
Date: Mon Aug 15 10:46:06 2022 +0300

    # Select3D_SensitiveCircle now inherits directly from Select3D_SensitiveEntity.
    # Added appropriate methods for selecting sensitive circles.
    # Added parameter myIsHollow to Select3D_SensitiveCylinder class.
    # It allows you to search for intersections with cylinders without covers.
    # Added tests: vselect/circle
    
    # TODO:
    # Define circle segments as sensitive polygons.
    # Add more hollow cylinder intersection tests.
    # Solve the problem with the inverted cylindrical surface.
    # Check how the sensitive circle intersection algorithm works with various transformations.
    # Reorganize the SelectMgr::ComputeSensitivePrs method, move the circle drawing to a separate method.
03Commenter 3
Branch [archived branch] has been updated by Commenter 1.

[revision removed]


Detailed log of new commits:

Author: Commenter 1
Date: Mon Aug 15 17:33:06 2022 +0300

    # Added Select3D_SensitiveCircleSector class for sensitive arc and segments.
    # Added test: vselect/circle/transformed
    
    # TODO:
    # Add more hollow cylinder intersection tests.
    # Solve the problem with the inverted cylindrical surface.
04Commenter 3
Branch [archived branch] has been updated by Commenter 1.

[revision removed]


Detailed log of new commits:

Author: Commenter 1
Date: Tue Aug 16 18:18:20 2022 +0300

    # Fixed some bugs
    # Added test: vselect/cone_cylinder/hollow_cone_cyl
    
    # TODO:
    # Solve the problem with the inverted cylindrical surface.
    # Update v3d/manipulator tests
05Commenter 3
Branch [archived branch] has been updated by Commenter 1.

[revision removed]


Detailed log of new commits:

Author: Commenter 1
Date: Thu Aug 18 15:30:24 2022 +0300

    # Fixed the problem with the inverted cylindrical surface.

Author: Commenter 1
Date: Thu Aug 18 11:39:46 2022 +0300

    # fix tests
06Commenter 3
Branch [archived branch] has been created by Commenter 1.

[revision removed]


Detailed log of new commits:

Author: Commenter 1
Date: Thu Aug 18 17:12:03 2022 +0300

    Select3D_SensitiveCircle now inherits directly from Select3D_SensitiveEntity.
    Added Select3D_SensitiveCircleSector class for sensitive arc and segments.
    
    Added appropriate methods for selecting sensitive circles.
    Added parameter myIsHollow to Select3D_SensitiveCylinder class.
    It allows you to search for intersections with cylinders without covers.
    
    Added tests: vselect/circle/circle_wire
                 vselect/circle/filled_circle
                 vselect/circle/transformed
                 vselect/cone_cylinder/hollow_cone_cyl
07Commenter 3
Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]
08Commenter 1
09Commenter 1
The patch CR32547 is ready to review
10Commenter 3
Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]
11Author
Please consider remarks.
12Commenter 3
Branch [archived branch] has been created by Commenter 1.

[revision removed]


Detailed log of new commits:

Author: Commenter 1
Date: Thu Aug 18 17:12:03 2022 +0300

    0032547: Visualization, Select3D_SensitiveCylinder - implement picking of a hollow cylinder
    
    Select3D_SensitiveCircle now inherits directly from Select3D_SensitiveEntity.
    The sensitive circle sector is created using the Select3D_SensitivePoly class directly.
    
    Added appropriate methods for selecting sensitive circles.
    Added parameter myIsHollow to Select3D_SensitiveCylinder class.
    It allows you to search for intersections with cylinders without covers.
    
    The Draw vcircle command has been extended with UStart and UEnd parameters
    to create a sector of a circle.
    
    Added tests: vselect/cone_cylinder/circle_sector
                 vselect/cone_cylinder/circle_wire
                 vselect/cone_cylinder/filled_circle
                 vselect/cone_cylinder/transformed
                 vselect/cone_cylinder/hollow_cone_cyl
13Commenter 3
Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]
14Commenter 3
Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]
15Commenter 3
Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]
16Commenter 1
The patch CR32547 is ready to review
17Author
Please raise the patch
- OCCT: branch CR32547_3.
18Commenter 18
Combination -
OCCT branch : [archived branch]
master SHA - changes and them, and you can discard any commits you make in this
[revision removed]
changes and them, and you can discard any commits you make in this
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18740.360000000626 / 18736.06000000064 [+0.02%]
Products
Total CPU difference: 11987.570000000105 / 11972.270000000151 [+0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 20800.71875 / 20773.21875 [+0.13%]
Products
Total CPU difference: 13554.96875 / 13548.546875 [+0.05%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
19Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]
20Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]
21Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]
22Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records