DiscussionsIssue archiveOCCT:Documentation

Archived issue #0032550

Documentation - Proofreading for "Tutorials and Samples -> Tutorial"

Open CASCADEOCCT:Documentationclosed14 public notes

Search issues

Description

Proofreading and new images for solid model for MakeBottle sample description.

Steps to reproduce

Tutorial source code updated

Public activity

14 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Sep 1 16:29:33 2021 +0300

    0032550: Proofreading for Tutorial
    
    New images added for better representation of solid model;
    Minor fixes for misprints and old classes;
    Proofreading done.
02Commenter 3
I'm not familiar with this tutorial.

New images have been obviously dumped from 3D viewer, but why this has been done without beautifier options (rendScale for antialiasing, mapping isoLines on triangulation to avoid artifacts)?
Does purple really a good color for a bottle in this document?
03Author
The goal of new images were to explicitly show that the result of the build is not a blue carcass thingy but an actual solid model. These images can be redone with better visual parameters if needed.
As for the purple color, this is kind of shade that is used for default 3DS MAX models and I thought it fits for representing the first modelling steps using this bottle. Additionally, I think it will both fit the overall color schema of the HTML Overview webpage and stand out enough if the user is scrolling the page to find the bottle building stage he is willing to check out. This also can be changed if it seems unfit here.
04Commenter 4
Boris, thank you very much for the patch.

I have one but important remark: resulting images are much bigger than older ones. So, the page looks a bit weird with new images.

You will have to rework images, so it is fruitful to utilize beautifiers mentioned by Kirill. Please, ask him how to embed them into a code and keep them in the patch.

05Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Sep 10 17:35:07 2021 +0300

    0032550: Proofreading for "Tutorials and Samples -> Tutorial"
    
    Remarks implemented:
    New graphic settings applied;
    New color for visual output set;
    New images added that are grabbed from the default window size.

06Commenter 6
Boris,

1. Please include beautifiers in the patch.
2. Images are too big; it is necessary to downscale them. The maximal image size should be 400x400.
07Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Sep 28 16:25:29 2021 +0300

    0032550: Proofreading for "Tutorials and Samples -> Tutorial"
    
    1. Beautifiers included.
    2. Images are scaled to match the requirements.

08Commenter 8
Beautifiers still missing.
09Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Sep 30 14:18:12 2021 +0300

    0032550: Proofreading for "Tutorials and Samples -> Tutorial"
    
    Beautifiers code included into the tutorial.

10Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
11Commenter 11
Update qt sample is built without errors:
http://jenkins-test-occt/view/CR32550-master-aml/view/SAMPLES/
12Commenter 12
Please raise the patch
- OCCT: branch CR32550.
13Commenter 13
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17464.590000000462 / 17476.150000000354 [-0.07%]
Products
Total CPU difference: 11405.930000000111 / 11390.180000000097 [+0.14%]
Windows-64-VC14:
OCCT
Total CPU difference: 19332.171875 / 19335.34375 [-0.02%]
Products
Total CPU difference: 12772.859375 / 12782.828125 [-0.08%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
14Commenter 2
Branch [archived branch] has been deleted by Commenter 3.

[revision removed]

Related records