DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0032717

Modeling Algorithms - BRepBuilderAPI_Copy should not remove triangulation from surface-less faces

Open CASCADEOCCT:Modeling Algorithmsclosed4 public notes

Search issues

Description

BRepBuilderAPI_Copy::Perform() has a flag `copyMesh` intended to avoid copying of triangulation in addition to geometry.
In case of triangulation-only geometry this operation produces an invalid empty faces, which makes no sense.

It is proposed ignoring this flag in such cases, similar to BRepTools::Clean().

Steps to reproduce

pload XDE MODELING
box b 1 2 3
incmesh b 1
checktrinfo b -tri 12 -nod 24
tclean -geom b
trinfo b
checktrinfo b -tri 12 -nod 24

tcopy b bb
trinfo bb
checktrinfo bb -tri 12 -nod 24
# KO - copied shape is empty

Public activity

4 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Dec 6 22:23:24 2021 +0300

    0032717: Modeling Algorithms - BRepBuilderAPI_Copy should not remove triangulation from surface-less faces
    
    BRepBuilderAPI_Copy now ignores toCopyMesh flag for non-geometric shapes.
02Author
Patch is ready for review
- OCCT: branch CR32717.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32717-master-KGV/
03Commenter 3
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18222.380000000427 / 18166.60000000042 [+0.31%]
Products
Total CPU difference: 11645.100000000084 / 11658.820000000103 [-0.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 19999.4375 / 19937.953125 [+0.31%]
Products
Total CPU difference: 13044.453125 / 13069.28125 [-0.19%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
04Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records