Archived issue #0032860

Coding Rules, Extrema_GenExtPS - add exported destructor

CommunityOCCT:Codingclosed5 public notes

Search issues

Description

Based on the following Forum topic, classes like BRepExtrema_ExtPF my lead Debug/Release MSVCRT mixture issues:
https://dev.opencascade.org/content/brepextremaextpf-throwing-exception-debug-mode-only

It is proposed to add destructors to BRepExtrema_ExtPF and similar classes to ensure that NCollection_Array2 is released using the same CRT as allocated by constructor/initializer.

Steps to reproduce

N/A

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Mar 2 08:18:29 2022 +0300

    0032860: Coding Rules, Extrema_GenExtPS - add exported destructor
    
    Added eplicit destructors to classes Extrema_GenExtCS, Extrema_GenExtPS and Extrema_GenExtSS.
02Author
Patch is ready for review
- OCCT: branch CR32860.

http://jenkins-test-occt/view/CR32860-master-KGV/view/OCCT%20compile/
03Commenter 3
Reviewed. Please rise the patch.

OCCT: CR32860
Products: -
04Commenter 4
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18394.330000000256 / 18467.180000000375 [-0.39%]
Products
Total CPU difference: 11708.150000000112 / 11716.630000000077 [-0.07%]
Windows-64-VC14:
OCCT
Total CPU difference: 20348.171875 / 20359.046875 [-0.05%]
Products
Total CPU difference: 13154.5625 / 13140.734375 [+0.11%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
05Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records