DiscussionsIssue archiveOCCT:Configuration

Archived issue #0032990

Configuration - compilation errors since Emscripten 3.1.11 due to time_t redefined long->int

CommunityOCCT:Configurationclosed8 public notes

Search issues

Description

Emscripten 3.1.11 has a breaking change in API time_t redefined long->int.
This leads to OCCT compilation errors due to definition of global IsEqual(time_t, time_t) method.

2022-05-24T09:45:10.4242458Z /occt/src/Standard/Standard_Time.hxx:29:25: error: redefinition of 'IsEqual'
2022-05-24T09:45:10.4243046Z inline Standard_Boolean IsEqual (const Standard_Time theOne,
2022-05-24T09:45:10.4243403Z                         ^
2022-05-24T09:45:10.4243891Z /occt/src/Standard/Standard_Integer.hxx:126:25: note: previous definition is here
2022-05-24T09:45:10.4244417Z inline Standard_Boolean IsEqual (const Standard_Integer theOne,
2022-05-24T09:45:10.4244753Z   

Steps to reproduce

N/A

Public activity

8 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri May 27 09:56:50 2022 +0300

    0032990: Configuration - compilation errors since Emscripten 3.1.11 due to time_t redefined long->int
    
    Add std::is_same filter to IsEqual(time_t, time_t) definition.
02Commenter 1
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Author
Patch is ready for review
- OCCT: branch CR32990.

http://jenkins-test-occt/view/CR32990-master-KGV/
04Commenter 4
I have no remarks, but could you please run jenkins again? I cannot open results of Windows-related testing.
05Author
Please check restarted job.
06Commenter 6
Reviewed.

For integration:
occt - CR32990
products - none
07Commenter 7
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18736.560000000623 / 18755.550000000607 [-0.10%]
Products
Total CPU difference: 11708.410000000114 / 11723.710000000106 [-0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 20637.375 / 20721.125 [-0.40%]
Products
Total CPU difference: 13299.6875 / 13249.9375 [+0.38%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
08Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]