DiscussionsIssue archiveOCCT:Visualization

Archived issue #0032991

Visualization, TKOpenGl - OpenGl_Window::Resize() ignores window virtual flag on macOS

Open CASCADEOCCT:Visualizationclosed7 public notes

Search issues

Description

While embedding OCCT viewer into external OpenGL engine, OpenGl_Window::Resize() should not rely on native window dimensions, as rendering might be done into offscreen FBO of different size.

Steps to reproduce

N/A

Public activity

7 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Sat May 28 01:04:31 2022 +0300

    0032991: Visualization, TKOpenGl - OpenGl_Window::Resize() ignores window virtual flag on macOS
    
    Added handling of Aspect_Window::IsVirtual() flag on macOS platform.
02Commenter 1
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Commenter 1
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Author
Patch is ready for review
- OCCT: branch CR32991.

http://jenkins-test-occt/view/CR32991-master-KGV/
05Commenter 5
The patch was reviewed
06Commenter 6
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18736.560000000623 / 18755.550000000607 [-0.10%]
Products
Total CPU difference: 11708.410000000114 / 11723.710000000106 [-0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 20637.375 / 20721.125 [-0.40%]
Products
Total CPU difference: 13299.6875 / 13249.9375 [+0.38%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
07Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]