Archived issue #0033055
Data Exchange, RWPly_Provider - remove dependency from BRepLib_PointCloudShape
Description
#0032821 introduced dependency of PLY export tool from Point Cloud generation algorithm BRepLib_PointCloudShape (hence, adding TKTopAlgo dependency to TKRWMesh).
This point cloud generation logic even though might be useful in some specific cases, in general looks unnatural in both aspects - PLY format is more appropriate for polygonal meshes rather than to point clouds, and point cloud generation is not quite a step that expected to be done implicitly by Data Exchange component.
Therefore, it is proposed removing this feature from `RWPly_Provider` (and moving elsewhere, if necessary - like a TKRWPointCloud component designed specifically to work with point clouds).
This point cloud generation logic even though might be useful in some specific cases, in general looks unnatural in both aspects - PLY format is more appropriate for polygonal meshes rather than to point clouds, and point cloud generation is not quite a step that expected to be done implicitly by Data Exchange component.
Therefore, it is proposed removing this feature from `RWPly_Provider` (and moving elsewhere, if necessary - like a TKRWPointCloud component designed specifically to work with point clouds).
Steps to reproduce
Not required
Public activity
13 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: atychini
Date: Mon Jul 11 16:07:23 2022 +0300
0033055: Data Exchange, RWPly_Provider - remove dependency from BRepLib_PointCloudShape
Removing PointCloud writing feature from the RWPly_Provider class.
[revision removed]
Detailed log of new commits:
Author: atychini
Date: Mon Jul 11 16:07:23 2022 +0300
0033055: Data Exchange, RWPly_Provider - remove dependency from BRepLib_PointCloudShape
Removing PointCloud writing feature from the RWPly_Provider class.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear msv, branch CR33055 is ready for review
All tests are ok, see http://jenkins-test-08.nnov.opencascade.com/view/CR33055-master-atychini/view/COMPARE/
All tests are ok, see http://jenkins-test-08.nnov.opencascade.com/view/CR33055-master-atychini/view/COMPARE/
Please also remove unused dependency TKTopAlgo from TKRWMesh
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
For integration:
occt - CR33055
products - none
occt - CR33055
products - none
-provider.PLY.OCC.write.pnt.set : 0 provider.PLY.OCC.write.distance : 0 provider.PLY.OCC.write.density : 2e+100 provider.PLY.OCC.write.tolerance : 1e-07
I have some feelings that 3 parameters below are also related to this removed point cloud export feature, and could be dropped as well.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear msv, tests have been completed successfully.
http://jenkins-test-08.nnov.opencascade.com/view/CR33055-master-atychini/view/ALL/
http://jenkins-test-08.nnov.opencascade.com/view/CR33055-master-atychini/view/ALL/
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Combination -
OCCT branch : [archived branch]
master SHA - changes and them, and you can discard any commits you make in this
[revision removed]
changes and them, and you can discard any commits you make in this
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18704.32000000071 / 18688.950000000597 [+0.08%]
Products
Total CPU difference: 11922.590000000118 / 11921.05000000012 [+0.01%]
Windows-64-VC14:
OCCT
Total CPU difference: 20723.546875 / 20746.84375 [-0.11%]
Products
Total CPU difference: 13486.40625 / 13479.375 [+0.05%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - changes and them, and you can discard any commits you make in this
[revision removed]
changes and them, and you can discard any commits you make in this
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18704.32000000071 / 18688.950000000597 [+0.08%]
Products
Total CPU difference: 11922.590000000118 / 11921.05000000012 [+0.01%]
Windows-64-VC14:
OCCT
Total CPU difference: 20723.546875 / 20746.84375 [-0.11%]
Products
Total CPU difference: 13486.40625 / 13479.375 [+0.05%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records