Archived issue #0033073

Coding Rules, RWGltf_CafWriter - suppress CLang warning coming from Draco library

Open CASCADEOCCT:Codingclosed4 public notes

Search issues

Description

The following compiler warnings (CLang from Emscripten SDK) should be suppressed:
In file included from C:\occt.git\src\RWGltf\RWGltf_CafWriter.cxx:48:
In file included from c:/draco-1.4.1-wasm32/include\draco/compression/encode.h:19:
In file included from c:/draco-1.4.1-wasm32/include\draco/compression/config/encoder_options.h:18:
In file included from c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_attribute.h:22:
c:/draco-1.4.1-wasm32/include\draco/core/data_buffer.h:61:42: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'size_t' (aka 'unsigned long') [-Wshorten-64-to-32]
           src_buf->data() + src_offset, size);
                                         ^~~~
In file included from C:\occt.git\src\RWGltf\RWGltf_CafWriter.cxx:48:
In file included from c:/draco-1.4.1-wasm32/include\draco/compression/encode.h:19:
In file included from c:/draco-1.4.1-wasm32/include\draco/compression/config/encoder_options.h:18:
In file included from c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_attribute.h:21:
In file included from c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_indices.h:22:
c:/draco-1.4.1-wasm32/include\draco/core/draco_index_type.h:150:25: warning: definition of implicit copy constructor for 'IndexType<unsigned int, draco::AttributeValueIndex_tag_type_>' is deprecated because it has a user-provided copy assignment operator [-Wdeprecated-copy-with-user-provided-copy]
  inline ThisIndexType &operator=(const ThisIndexType &i) {
                        ^
c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_attribute.h:107:41: note: in implicit copy constructor for 'draco::IndexType<unsigned int, draco::AttributeValueIndex_tag_type_>' first required here
    const int64_t byte_pos = GetBytePos(att_index);
                                        ^
c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_attribute.h:122:39: warning: implicit conversion loses integer precision: 'const int64_t' (aka 'const long long') to 'size_t' (aka 'unsigned long') [-Wshorten-64-to-32]
    buffer_->Read(byte_pos, out_data, byte_stride_);
             ~~~~                     ^~~~~~~~~~~~
c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_attribute.h:129:37: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'size_t' (aka 'unsigned long') [-Wshorten-64-to-32]
    buffer_->Write(byte_pos, value, byte_stride());
             ~~~~~                  ^~~~~~~~~~~~~
In file included from C:\occt.git\src\RWGltf\RWGltf_CafWriter.cxx:48:
In file included from c:/draco-1.4.1-wasm32/include\draco/compression/encode.h:19:
In file included from c:/draco-1.4.1-wasm32/include\draco/compression/config/encoder_options.h:18:
In file included from c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_attribute.h:21:
In file included from c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_indices.h:22:
c:/draco-1.4.1-wasm32/include\draco/core/draco_index_type.h:150:25: warning: definition of implicit copy constructor for 'IndexType<unsigned int, draco::PointIndex_tag_type_>' is deprecated because it has a user-provided copy assignment operator [-Wdeprecated-copy-with-user-provided-copy]
  inline ThisIndexType &operator=(const ThisIndexType &i) {
                        ^
c:/draco-1.4.1-wasm32/include\draco/attributes/point_attribute.h:72:36: note: in implicit copy constructor for 'draco::IndexType<unsigned int, draco::PointIndex_tag_type_>' first required here
    return GetAddress(mapped_index(point_index));
                                   ^
In file included from C:\occt.git\src\RWGltf\RWGltf_CafWriter.cxx:48:
In file included from c:/draco-1.4.1-wasm32/include\draco/compression/encode.h:19:
In file included from c:/draco-1.4.1-wasm32/include\draco/compression/config/encoder_options.h:18:
In file included from c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_attribute.h:21:
In file included from c:/draco-1.4.1-wasm32/include\draco/attributes/geometry_indices.h:22:
c:/draco-1.4.1-wasm32/include\draco/core/draco_index_type.h:150:25: warning: definition of implicit copy constructor for 'IndexType<unsigned int, draco::FaceIndex_tag_type_>' is deprecated because it has a user-provided copy assignment operator [-Wdeprecated-copy-with-user-provided-copy]
  inline ThisIndexType &operator=(const ThisIndexType &i) {
                        ^
c:/draco-1.4.1-wasm32/include\draco/mesh/mesh.h:99:23: note: in implicit copy constructor for 'draco::IndexType<unsigned int, draco::FaceIndex_tag_type_>' first required here
    return this->face(FaceIndex(ci / 3))[ci % 3];
                      ^
6 warnings generated.

Steps to reproduce

N/A

Public activity

4 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Jul 22 09:53:33 2022 +0300

    0033073: Coding Rules, RWGltf_CafWriter - suppress CLang warning coming from Draco library
02Author
Please raise the fix
- OCCT: branch CR33073.
03Commenter 3
Combination -
OCCT branch : [archived branch]
master SHA - changes and them, and you can discard any commits you make in this
[revision removed]
changes and them, and you can discard any commits you make in this
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18704.32000000071 / 18688.950000000597 [+0.08%]
Products
Total CPU difference: 11922.590000000118 / 11921.05000000012 [+0.01%]
Windows-64-VC14:
OCCT
Total CPU difference: 20723.546875 / 20746.84375 [-0.11%]
Products
Total CPU difference: 13486.40625 / 13479.375 [+0.05%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
04Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records