Visualization - AIS_Animation returns 0 elapsed time after finishing playback

Random image deviations on v3d anim videorecorder (videorecorder_10.png) might be related to this issue.

Branch [archived branch] has been created by Commenter 1.

[revision removed]


Detailed log of new commits:

Author: Commenter 1
Date: Fri Sep 2 18:08:46 2022 +0300

    0033114: Visualization - AIS_Animation returns 0 elapsed time after finishing playback

Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]

Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]

The patch CR33114 is ready to review

@@ -220,6 +220,7 @@ void AIS_Animation::Start (const Standard_Boolean theToUpdate)
 
   if (!myTimer.IsNull())
   {
+    myTimer->Seek (0.0);
     myTimer->Start();

It is better to keep old behavior of AIS_Animation::Start() to avoid disruption of existing applications relying on it.

+    theAnimationNew->SetTimer (theAnimation->Timer());
     theAnimation = theAnimationNew;

Please bring some comment here (in the bugtracker or commit message) to clarify a reason for this change.

+  Standard_Boolean isShowElapsedTime = Standard_False;

`toPrintElapsedTime`

+    if (isShowElapsedTime && !anAnimation->Timer().IsNull())
+    {
+      theDI << "Elapsed Time, sec: " << anAnimation->ElapsedTime() << "\n";
+    }

If timer is NULL, then elapsed time is `0`.

@@ -252,6 +253,7 @@ void AIS_Animation::Stop()
   if (!myTimer.IsNull())
   {
     myTimer->Stop();
+    myTimer->Seek (Duration());

This looks like a wrong place to forcefully set Duration() here - user may call Stop() in the middle of animation as well.
But in this place you may put something like clamping - e.g. if Duration() > 0.0 then Seek(Min (Duration(), Elapsed)).

Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]

Branch [archived branch] has been created by Commenter 1.

[revision removed]


Detailed log of new commits:

Author: Commenter 1
Date: Fri Sep 2 18:08:46 2022 +0300

    0033114: Visualization - AIS_Animation returns 0 elapsed time after finishing playback
    
    Added -elapsedTime option to DRAW vanim command

+      theDI << "Elapsed Time, sec: " << anAnimation->ElapsedTime() << "\n";

theDI << "Elapsed Time: " << anAnimation->ElapsedTime() << " s\n";

-  ViewerTest::CurrentEventManager()->AbortViewAnimation();
-  ViewerTest::CurrentEventManager()->SetObjectsAnimation (Handle(AIS_Animation)());
   if (!toPlay && aRecFile.IsEmpty())
   {
+    if (toPrintElapsedTime)
+    {
+      theDI << "Elapsed Time, sec: " << anAnimation->ElapsedTime() << "\n";
+    }
     return 0;
   }
 
+  ViewerTest::CurrentEventManager()->AbortViewAnimation();
+  ViewerTest::CurrentEventManager()->SetObjectsAnimation (Handle(AIS_Animation)());

Please restore logic with stopping playback and move `if (toPrintElapsedTime)` block outside of `toPlay` checks.

+Standard_Real AIS_Animation::ElapsedTime() const

I'm not sure it worth putting this logic into this method, as it would lead to different values with the timer.
Is there a reason why we cannot Seek() timer instead?

Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]

Branch [archived branch] has been updated forcibly by Commenter 1.

[revision removed]

Combination -
OCCT branch : [archived branch]
master SHA - changes and them, and you can discard any commits you make in this
[revision removed]
changes and them, and you can discard any commits you make in this
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18666.730000000585 / 18776.180000000597 [-0.58%]
Products
Total CPU difference: 11867.75000000012 / 11959.870000000119 [-0.77%]
Windows-64-VC14:
OCCT
Total CPU difference: 20851.8125 / 20857.796875 [-0.03%]
Products
Total CPU difference: 14092.984375 / 14084.640625 [+0.06%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]