Archived issue #0033140
Coding, Jt Import - Incrorrect layer's string conversion [REGRESSION since 0033125]
Description
There is danger piece of code after changing type of `myActiveLayer` from
`TCollection_ExtendedString` to `TCollection_AsciiString`.
myActiveLayer = aLFProperty->Value;
myActiveLayer.Remove(1, aAFName.Length() + 1);
The problem is that the length of myActiveLayer could not
equal the length of `aLFProperty->Value`.
So, we should firstly trim `TCollection_ExtendedString` string,
and only after this casting it to `TCollection_AsciiString`.
`TCollection_ExtendedString` to `TCollection_AsciiString`.
myActiveLayer = aLFProperty->Value;
myActiveLayer.Remove(1, aAFName.Length() + 1);
The problem is that the length of myActiveLayer could not
equal the length of `aLFProperty->Value`.
So, we should firstly trim `TCollection_ExtendedString` string,
and only after this casting it to `TCollection_AsciiString`.
Steps to reproduce
Not required
Public activity
4 archived notes
Participants are labeled by their role within this record.
somethins wrong with issue summery and with commit description
For example: #0032748
I thins the discription should be -> 033140: Coding, JtImport - Incrorrect layer's string conversion" or something equal.
I think we can not use a "033140: Coding, JtImport - Incrorrect layer's string conversion [REGRESSION]" but you can. The important thing - this thicket should be *Child of * ticket contains regression
Commenter 4, i have fully recycled the commit title and commit message,
as BUG title / message. Please, see it.
as BUG title / message. Please, see it.
Branch CR33140 was reviewed
Combination -
OCCT branch : [archived branch]
master SHA - changes and them, and you can discard any commits you make in this
[revision removed]
changes and them, and you can discard any commits you make in this
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18666.730000000585 / 18776.180000000597 [-0.58%]
Products
Total CPU difference: 11867.75000000012 / 11959.870000000119 [-0.77%]
Windows-64-VC14:
OCCT
Total CPU difference: 20851.8125 / 20857.796875 [-0.03%]
Products
Total CPU difference: 14092.984375 / 14084.640625 [+0.06%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - changes and them, and you can discard any commits you make in this
[revision removed]
changes and them, and you can discard any commits you make in this
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18666.730000000585 / 18776.180000000597 [-0.58%]
Products
Total CPU difference: 11867.75000000012 / 11959.870000000119 [-0.77%]
Windows-64-VC14:
OCCT
Total CPU difference: 20851.8125 / 20857.796875 [-0.03%]
Products
Total CPU difference: 14092.984375 / 14084.640625 [+0.06%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention