Archived issue #0033187

Modeling Algorithms - Crash in postprocessing of imported shape

Open CASCADEOCCT:Modeling Algorithmsverified14 public notes

Description

File Office.x_t from issue 0030459 can't be imported with enabled shape healing, exception arrises.
Problem is in GeomAdaptor_Curve::NbIntervals and GeomAdaptor_Curve::Intervals functions.
First of them calculates number of intervals, then array is created and second of them fills the array.
The number of intervals (array size) is less than need for filling.
Desynchronization of function behavior.
Small part of initial file were localized to "brep" for test purposes.

Steps to reproduce

pload MODELING
restore [locate_data Attachment 2 (BREP)] s
fixshape r s

Public activity

14 archived notes

Participants are labeled by their role within this record.

01Commenter 12022-10-31 15:53

Branch [archived branch] has been created by Author.

[revision removed]

Detailed log of new commits:

Author: Author
Date: Wed Oct 26 16:59:54 2022 +0300

    0033187: Modeling Algorithms - Crash in postprocessing of imported shape

    Problem: Desynchronization of behaviors of GeomAdaptor_Curve::NbIntervals and
     GeomAdaptor_Curve::Intervals functions. First calculates number of intervals, then
     array is created and second fills the array. In some cases the size of array
     is less than need for filling.

    Change:
    1. Added function BSplCLib::Intervals that calculates number of interval and fills
     the array with its (if needed).
    2. Simplified the algorithm of intervals calculation.
    3. GeomAdaptor_Curve::NbIntervals/Intervals and Geom2dAdaptor_Curve::NbIntervals/Intervals
     use BSplCLib::Intervals.
    4. Test for problem shape was created: bugs modalg_8 bug33187.

    Result: The new approach eliminates the problem of writing outside the array bounds.

02Commenter 42022-10-31 16:09

Attachment 2 (BREP) (702,632 bytes)

03Commenter 12022-10-31 16:10

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

04Commenter 62022-11-01 14:07

Results for offset curve, based on attached bspline curve bc seem to be wrong:
OCC29745 bc 2 -1 9
NbIntervals: 5; -1 1 3.0943951023932001 5.1887902047863896 7.2831853071795898 9
offset obc bc 1 0 0 1
OCC29745 obc 1 -1 9
NbIntervals: 4; -1 1 3.0943951023932001 5.1887902047863896 9

Intervals C1 for offset curve and C2 for base curve must be the same.

This problem exists for current master too.

05Commenter 72022-11-01 14:08

bc (238 bytes)

06Commenter 12022-11-01 16:05

Branch [archived branch] has been updated by Author.

[revision removed]

Detailed log of new commits:

Author: Author
Date: Tue Nov 1 16:05:36 2022 +0300

# fix offset curve adaptor boundaries

07Commenter 92022-11-02 10:21

Issue with offset curve has been fixed.

Draw[72]> pload QAcommands MODELING
Draw[73]> restore [locate_data bc] bc
bc
Draw[74]> OCC29745 bc 2 -1 9
NbIntervals: 5; -1 1 3.0943951023932001 5.1887902047863896 7.2831853071795898 9
Draw[75]> offset obc bc 1 0 0 1
Draw[76]> OCC29745 obc 1 -1 9
NbIntervals: 5; -1 1 3.0943951023932001 5.1887902047863896 7.2831853071795898 9

All tests are passed.
http://jenkins-test-occt.nnov.opencascade.com/view/CR33187-master-Author/view/COMPARE/

08Commenter 22022-11-02 10:37

Dear ~~Commenter 2~~, join all commits in one commit with correct header and description of shanges.

09Commenter 12022-11-02 11:30

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

10Commenter 122022-11-02 11:36

Commits were squashed. Changes about offset curve were added to commit description.

11Commenter 132022-11-02 12:21

Branch CR33187 seems to be valid

12Commenter 12022-11-02 16:46

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

13Commenter 12022-11-03 10:19

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

14Commenter 12024-09-14 22:08

Branch [archived branch] has been deleted by Commenter 5.

[revision removed]