Archived issue #0033474
Data Exchange - Implement stream reading into RWMesh interface
Description
It's necessary to implement the ability to read from a stream by adding several new methods for readers.
Public activity
27 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: ichesnok
Date: Tue Sep 12 11:58:55 2023 +0100
0033474: Data Exchange - Implement stream reading into RWMesh interface
Stream usage as parameter
[revision removed]
Detailed log of new commits:
Author: ichesnok
Date: Tue Sep 12 11:58:55 2023 +0100
0033474: Data Exchange - Implement stream reading into RWMesh interface
Stream usage as parameter
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear Author,
please review branch CR33474
Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33474-master-ichesnok/view/COMPARE/
please review branch CR33474
Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33474-master-ichesnok/view/COMPARE/
Dear ichesnokova,
I looked throw the patch and have one remark, but it occurs in several files. It is about the "theFile" parameter it is totally unclear, what it means. In some files the description is missing, in some, it confuses ("path of additional file(s)").
As far as I understand, this parameter should mean the folder with additional files, so I would ask you to update the name (theFolder/theCatalog/... not single theFile) of the parameter and add/update the description to make this parameter clear in all the touched files.
After such an update, retest won't be necessary.
I looked throw the patch and have one remark, but it occurs in several files. It is about the "theFile" parameter it is totally unclear, what it means. In some files the description is missing, in some, it confuses ("path of additional file(s)").
As far as I understand, this parameter should mean the folder with additional files, so I would ask you to update the name (theFolder/theCatalog/... not single theFile) of the parameter and add/update the description to make this parameter clear in all the touched files.
After such an update, retest won't be necessary.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: ichesnok
Date: Tue Oct 24 12:08:07 2023 +0100
remark fixed
Author: ichesnok
Date: Tue Sep 12 11:58:55 2023 +0100
0033474: Data Exchange - Implement stream reading into RWMesh interface
Stream usage as parameter
[revision removed]
Detailed log of new commits:
Author: ichesnok
Date: Tue Oct 24 12:08:07 2023 +0100
remark fixed
Author: ichesnok
Date: Tue Sep 12 11:58:55 2023 +0100
0033474: Data Exchange - Implement stream reading into RWMesh interface
Stream usage as parameter
Dear ika,
please review branch CR33474_1.
please review branch CR33474_1.
Dear ichesnokova,
please add the description to the issue.
I have several style/text remarks. The retesting is not necessary after the applying.
1) RWObj_CafReader.hxx, RWGltf_CafReader.hxx
Add a description of the parameters to the method
2) VrmlAPI_CafReader.hxx
Add spaces into "std::istream& theStream," to align the parameter list.
3) RWObj_Reader.cxx
a)Message::SendFail (TCollection_AsciiString ("Error: file is not found"));
I think such an error message is not valid for the streams, please update them so that the text will be correct for both cases.
b) // determine file location to load associated files
unnecessary comment with a new approach
4) RWGltf_CafReader.cxx
Message::SendFail (TCollection_AsciiString ("The stream can't be open"));
The inverted case of (3a), also please make valid for both file and stream invalidity.
5) RWMesh_CafReader.cxx
Add method separator before Standard_Boolean RWMesh_CafReader::performMesh()
6) RWMesh_CafReader.hxx
+ TCollection_AsciiString myFilePath;
Please add a description to the new pole.
please add the description to the issue.
I have several style/text remarks. The retesting is not necessary after the applying.
1) RWObj_CafReader.hxx, RWGltf_CafReader.hxx
Add a description of the parameters to the method
2) VrmlAPI_CafReader.hxx
Add spaces into "std::istream& theStream," to align the parameter list.
3) RWObj_Reader.cxx
a)Message::SendFail (TCollection_AsciiString ("Error: file is not found"));
I think such an error message is not valid for the streams, please update them so that the text will be correct for both cases.
b) // determine file location to load associated files
unnecessary comment with a new approach
4) RWGltf_CafReader.cxx
Message::SendFail (TCollection_AsciiString ("The stream can't be open"));
The inverted case of (3a), also please make valid for both file and stream invalidity.
5) RWMesh_CafReader.cxx
Add method separator before Standard_Boolean RWMesh_CafReader::performMesh()
6) RWMesh_CafReader.hxx
+ TCollection_AsciiString myFilePath;
Please add a description to the new pole.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear ika,
please review branch CR33474_1.
please review branch CR33474_1.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: ichesnok
Date: Tue Sep 12 11:58:55 2023 +0100
0033474: Data Exchange - Implement stream reading into RWMesh interface
Several new functions has been added to readers for stream reading.
[revision removed]
Detailed log of new commits:
Author: ichesnok
Date: Tue Sep 12 11:58:55 2023 +0100
0033474: Data Exchange - Implement stream reading into RWMesh interface
Several new functions has been added to readers for stream reading.
No more remarks.
Dear bugmaster,
please integrate:
OCCT CR33474_2
Dear bugmaster,
please integrate:
OCCT CR33474_2
Dear ichesnokova,
I reject this ticket from IR-2023-11-10, because it has errors during compilation. Please check everything again and make fixes if they are needed.
http://jenkins-test-10.nnov.opencascade.com/job/CR33474-master-ichesnok-Products-Ubuntu2004-64-opt-compile/3/parsed_console/
http://jenkins-test-10.nnov.opencascade.com/job/CR33474-master-ichesnok-Products-Windows-64-VC142-opt-compile/3/parsed_console/
I reject this ticket from IR-2023-11-10, because it has errors during compilation. Please check everything again and make fixes if they are needed.
http://jenkins-test-10.nnov.opencascade.com/job/CR33474-master-ichesnok-Products-Ubuntu2004-64-opt-compile/3/parsed_console/
http://jenkins-test-10.nnov.opencascade.com/job/CR33474-master-ichesnok-Products-Windows-64-VC142-opt-compile/3/parsed_console/
Dear ika,
please review branch CR33474 (OCCT Products).
please review branch CR33474 (OCCT Products).
Dear ichesnokova,
please update comments about the method parameters (add for theStream, and update for theFile).
Also, please do not forget to rebase the branch to the current master.
please update comments about the method parameters (add for theStream, and update for theFile).
Also, please do not forget to rebase the branch to the current master.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear ika,
please review branch CR33474.
please review branch CR33474.
it will be a part of 7.8
I will include it into Release candidate.
I will include it into Release candidate.
Dear ika, please review branch CR33474.
Previous problem was a result of the same problem PROD branch was forgotten.
Please write a repo and correct branches name.
The tests were OK all time. Compilation errors was as a result of missing PROD commit.
Integrated into CR0-780
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records