Archived issue #0021690
"cpulimit" commad does not implemented on Win32 platform
Description
At the moment, "cpulimit" DRAW command has only unix part of implementation.
See the package "Draw", file Draw_BasicCommands.cxx, lines 208-244
By the way, SWDRAW package has needed implementation for WNT platform.
see the file cpulimit.pc
To resolve this issue I propose move implementation from SWDRAW package to Draw.
See the package "Draw", file Draw_BasicCommands.cxx, lines 208-244
By the way, SWDRAW package has needed implementation for WNT platform.
see the file cpulimit.pc
To resolve this issue I propose move implementation from SWDRAW package to Draw.
Public activity
9 archived notes
Participants are labeled by their role within this record.
SVN branch http://svn/svn/occt/branches/OCC21690 (revision 9663) is ready to be reviewed (implementation "cpulimit" DRAW command for WNT platform).
Code review remarks:
(a) it is bad practice to commit in one set changes made for the fix and update from trunk, please avoid this in the future
(b) as soon as implementation in SWDRAW/cpulimit.pc becomes unuseful, could you please remove it?
(a) it is bad practice to commit in one set changes made for the fix and update from trunk, please avoid this in the future
(b) as soon as implementation in SWDRAW/cpulimit.pc becomes unuseful, could you please remove it?
SVN branch http://svn/svn/occt/branches/OCC21690 is ready.
In package SWDRAW command "limitelapsed" for Win32 platform and file "cpulimit.pc" with its implementation has been removed. This is done because the functionality of command "limitelapsed" transferred to the command "cpulimit" in package DRAW.
In package SWDRAW command "limitelapsed" for Win32 platform and file "cpulimit.pc" with its implementation has been removed. This is done because the functionality of command "limitelapsed" transferred to the command "cpulimit" in package DRAW.
Reviewed with no remarks; please test and use in testing on WNT
Dear Commenter 1,
Workbench KAS:dev:mkv-21690-occt was updated from SVN branch http://svn/svn/occt/branches/OCC21690
(and mkv-21690-products from trunk) and compiled on Linux platform.
There are compilation errors in mkv-21690-occt:
Info : -------> Draw_BasicCommands.cxx
Error : Errors occured in Shell
/dn47/KAS/dev/mkv-21690-occt/src/Draw/Draw_BasicCommands.cxx:217: error: expected initializer before в__CpuFuncв_T
Error : Failed : Draw_BasicCommands.cxx
Info : ----------------------- Compilation Report -----------------------
Info : Failed : :KAS:dev:mkv-21690-occt:Draw:source:Draw_BasicCommands.cxx
Info : -----------------------------------------------------------------
Workbench KAS:dev:mkv-21690-occt was updated from SVN branch http://svn/svn/occt/branches/OCC21690
(and mkv-21690-products from trunk) and compiled on Linux platform.
There are compilation errors in mkv-21690-occt:
Info : -------> Draw_BasicCommands.cxx
Error : Errors occured in Shell
/dn47/KAS/dev/mkv-21690-occt/src/Draw/Draw_BasicCommands.cxx:217: error: expected initializer before в__CpuFuncв_T
Error : Failed : Draw_BasicCommands.cxx
Info : ----------------------- Compilation Report -----------------------
Info : Failed : :KAS:dev:mkv-21690-occt:Draw:source:Draw_BasicCommands.cxx
Info : -----------------------------------------------------------------
SVN branch http://svn/svn/occt/branches/OCC21690 (revision 9699): correction for compilation on Linux platform.
*RESTORED*
(0018818) abv (administrator) - 2011-12-09 20:19
#0021690
----------------------------------------------------------------------
No remarks on code; please do not forget to switch bugs to resolved state when
you provide the fix
(0018818) abv (administrator) - 2011-12-09 20:19
#0021690
----------------------------------------------------------------------
No remarks on code; please do not forget to switch bugs to resolved state when
you provide the fix
Dear Commenter 1,
Workbench KAS:dev:mkv-21690-occt was updated from SVN branch http://svn/svn/occt/branches/OCC21690
(and mkv-21690-products from trunk) and compiled on Linux platform.
There are not regressions in mkv-21690-products regarding to KAS:dev:products-652-opt.
See results in /QADisk/occttests/results/KAS/dev/mkv-21690-products_09122011/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
Workbench KAS:dev:mkv-21690-occt was updated from SVN branch http://svn/svn/occt/branches/OCC21690
(and mkv-21690-products from trunk) and compiled on Linux platform.
There are not regressions in mkv-21690-products regarding to KAS:dev:products-652-opt.
See results in /QADisk/occttests/results/KAS/dev/mkv-21690-products_09122011/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification
Integrated into trunk of occt repository
Date: 2011-12-16 16:10:37 +0400 (Fri, 16 Dec 2011)
New Revision: 9768
Removed:
trunk/src/SWDRAW/FILES
trunk/src/SWDRAW/cpulimit.pc
Modified:
trunk/src/Draw/Draw_BasicCommands.cxx
trunk/src/SWDRAW/SWDRAW.cxx
Date: 2011-12-16 16:10:37 +0400 (Fri, 16 Dec 2011)
New Revision: 9768
Removed:
trunk/src/SWDRAW/FILES
trunk/src/SWDRAW/cpulimit.pc
Modified:
trunk/src/Draw/Draw_BasicCommands.cxx
trunk/src/SWDRAW/SWDRAW.cxx