Archived issue #0024881
Wrong status returned by ShapeFix_Wire::FixGaps3d () operation
Description
Attempt to apply ShapeFix_Wire::FixGaps3d () to a valid shape returns wrong status
FAIL2 (ShapeAnalysis_WireOrder failed).
As input shape can be used any valid shape, for example ordinary Box.
FAIL2 (ShapeAnalysis_WireOrder failed).
As input shape can be used any valid shape, for example ordinary Box.
Steps to reproduce
To reproduce the specified problem the attached script Attachment 1 (BAT) can be used.
Before using the script it is necessary to open the Attachment 1 (BAT) file and modify
environment variable PRODROOT (it should point to OCCT root directory.
cmd> Attachment 1 (BAT) box.brep
//=================================================
Before the fix: "Fix_FillGaps_3dSomeGapsFail, nb failed = 6"
After the fix: "Fix_FillGaps_NothingToDo"
Before using the script it is necessary to open the Attachment 1 (BAT) file and modify
environment variable PRODROOT (it should point to OCCT root directory.
cmd> Attachment 1 (BAT) box.brep
//=================================================
Before the fix: "Fix_FillGaps_3dSomeGapsFail, nb failed = 6"
After the fix: "Fix_FillGaps_NothingToDo"
Public activity
7 archived notes
Participants are labeled by their role within this record.
Is this issue still relevant??
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: akz
Date: Tue Feb 10 11:47:42 2015 +0300
0024881: Wrong status returned by ShapeFix_Wire::FixGaps3d () operation
The reason of FAIL status of FixGaps3d is that the trying to convert
curves to BSplines on valid edges (both adjacent points saticfy a
precision) leads to skipping of the convertation and gives wrong status.
Check of the gap on adjacent points before try ro convert curves was
added.
[revision removed]
Detailed log of new commits:
Author: akz
Date: Tue Feb 10 11:47:42 2015 +0300
0024881: Wrong status returned by ShapeFix_Wire::FixGaps3d () operation
The reason of FAIL status of FixGaps3d is that the trying to convert
curves to BSplines on valid edges (both adjacent points saticfy a
precision) leads to skipping of the convertation and gives wrong status.
Check of the gap on adjacent points before try ro convert curves was
added.
Branch CR24881 is ready to review.
Branch CR24881 is ready to be tested
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: apv
Date: Thu Feb 12 11:17:30 2015 +0300
Test-case for issue #0024881
[revision removed]
Detailed log of new commits:
Author: apv
Date: Thu Feb 12 11:17:30 2015 +0300
Test-case for issue #0024881
Dear Commenter 1,
Branch CR24881 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 18 (18 on master)
Windows: 0 (0 on master)
products component:
Linux: 11 (11 on master)
Windows: 1 (1 on master)
Regressions/Differences:
Not detected
Testing cases:
bugs heal(017) bug24881 - OK
http://occt-tests/CR24881-master-occt/Debian60-64/bugs/heal/bug24881.html
http://occt-tests/CR24881-master-occt/Windows-32-VC10/bugs/heal/bug24881.html
Testing on Linux:
Total MEMORY difference: 86193499 / 86229117
Total CPU difference: 48746.729999999894 / 47876.709999999846
Testing on Windows:
Total MEMORY difference: 40648511 / 40658608
Total CPU difference: 38009.140625 / 32754.1875
Branch CR24881 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 18 (18 on master)
Windows: 0 (0 on master)
products component:
Linux: 11 (11 on master)
Windows: 1 (1 on master)
Regressions/Differences:
Not detected
Testing cases:
bugs heal(017) bug24881 - OK
http://occt-tests/CR24881-master-occt/Debian60-64/bugs/heal/bug24881.html
http://occt-tests/CR24881-master-occt/Windows-32-VC10/bugs/heal/bug24881.html
Testing on Linux:
Total MEMORY difference: 86193499 / 86229117
Total CPU difference: 48746.729999999894 / 47876.709999999846
Testing on Windows:
Total MEMORY difference: 40648511 / 40658608
Total CPU difference: 38009.140625 / 32754.1875
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]