DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0025237

Wrong result of COMMON operation

Open CASCADEOCCT:Modeling Algorithmsclosed11 public notes

Search issues

Description

Wrong result of COMMON operation applied to attached edges.

Steps to reproduce

restore b26 e1
restore b5 e2
bop e1 e2
bopcommon r
# r is empty

Additional information

Modifications in Edge/Edge intersection algorithm:
1. Condition to create common part of type TopAbs_EDGE is changed.
2. Correct treatment of closed edges.

Public activity

11 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Sep 12 12:03:18 2014 +0400

    0025237: Wrong result of COMMON operation
    
    Modifications in Edge/Edge intersection algorithm:
    1. Condition to create common part of type TopAbs_EDGE is changed.
    2. Correct treatment of closed edges.
02Commenter 2
Git branch CR25237 is ready to be reviewed.
03Commenter 3
Reviewed
04Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
05Commenter 5
Dear Commenter 1,

Branch CR25237 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 16 (15 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 11 (11 on master)
   Windows: 1 (1 on master)
There is new additional compilation warnings on Linux platform:
IntTools_EdgeEdge.cxx:583, GNU C Compiler 4 (gcc), Priority: Normal
suggest parentheses around ‘&&’ within ‘||’

Regressions/Differences:
Not detected

Testing cases:
Not done

Testing on Linux:
Total MEMORY difference: 355316420 / 355211896
Total CPU difference: 43231.46000000028 / 45410.72000000016

Testing on Windows:
Total MEMORY difference: 242240820 / 241910488
Total CPU difference: 39274.53125 / 42620.859375
06Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Sep 18 16:58:45 2014 +0400

    Small correction to eliminate warning.

07Commenter 7
Warning has been removed. Please test.
08Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
09Commenter 2
Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: apv
Date: Mon Sep 22 18:46:16 2014 +0400

    Test case for issue #0025237

10Commenter 10
Dear Commenter 1,

Branch CR25237 (and products from GIT master) was compiled on Linux, Windows and MacOS platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 15 (15 on master)
   Windows: 0 (0 on master)
   MacOS: 193 (193 on master)
products component:
   Linux: 11 (11 on master)
   Windows: 1 (1 on master)

Regressions/Differences:
Not detected

Testing case:
bugs modalg_5(010) bug25237 - OK
http://occt-tests/CR25237-master-occt/Debian60-64/bugs/modalg_5/bug25237.html
http://occt-tests/CR25237-master-occt/Windows-32-VC10/bugs/modalg_5/bug25237.html

Testing on Linux:
Total MEMORY difference: 355243580 / 355491948
Total CPU difference: 43686.4399999999 / 44819.06000000009

Testing on Windows:
Total MEMORY difference: 242577068 / 242267280
Total CPU difference: 35152.015625 / 34303.3125
11Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]