Archived issue #0026426

Draft angle algorithm modifies input argument + the result of the operation have very large tolerance values

Open CASCADEOCCT:Modeling Algorithmsclosed26 public notes

Description

Draft Angle operation increases dramatically the tolerance values of the sub-shapes of input argument. The tolerance values of the sub-shapes of the result of the operation are very large.

Steps to reproduce

restore Attachment 1 (BREP) b1
tolerance b1
# Tolerance MAX=2.[revision removed]-007 MIN=9.[revision removed]-008
# FACE : MAX=9.[revision removed]-008 MIN=9.[revision removed]-008
# EDGE : MAX=2.[revision removed]-007 MIN=9.[revision removed]-008
# VERTEX : MAX=2.[revision removed]-007 MIN=1.[revision removed]-007
explode b1 f
depouille r b1 0 0 -1 b1_1 -10 0 0 -40 0 0 1

tolerance b1
# Tolerance MAX=5.289809421253965 MIN=9.[revision removed]-008
# FACE : MAX=9.[revision removed]-008 MIN=9.[revision removed]-008
# EDGE : MAX=2.[revision removed]-007 MIN=9.[revision removed]-008
# VERTEX : MAX=5.289809421253965 MIN=1.[revision removed]-007

tolerance r
# Tolerance MAX=5.289809421253965 MIN=9.[revision removed]-008
# FACE : MAX=9.[revision removed]-008 MIN=9.[revision removed]-008
# EDGE : MAX=5.2898094212539633 MIN=9.[revision removed]-008
# VERTEX : MAX=5.289809421253965 MIN=1.[revision removed]-007

Public activity

26 archived notes

Participants are labeled by their role within this record.

01Commenter 12015-07-14 09:29

This issue is one more case for the general task "Non-destructive principle in algorithms".

02Commenter 22015-07-17 10:01

Branch [archived branch] has been created by Participant.

[revision removed]

Detailed log of new commits:

Author: ifv
Date: Fri Jul 17 09:43:21 2015 +0300

0026426: Draft angle algorithm modifies input argument + the result of the operation have very large tolerance values

03Commenter 32015-07-17 10:03

Please, review branch CR26426

04Commenter 42015-07-17 10:17

Reviewed.

05Commenter 52015-07-21 17:09

Dear Commenter 1,

Branch CR26426 from occt git-repository (and IR-2015-07-09 from products git-repository) was compiled on Linux and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 24 (24 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 37 (37 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
http://occt-tests/CR26426-IR-2015-07-09-occt-64/Debian70-64/summary.html
http://occt-tests/CR26426-IR-2015-07-09-occt-64/Windows-64-VC10/summary.html
bugs modalg_2 bug422_1, bug422_2
bugs modalg_4 bug712_1
draft angle A9, B1, D9, E6, E7, E9, F1, F2, F3, F4, F5, F7, F8, G1, G3, G6, G9, H1, H2, H3, H5, H6, H7, I2, I3, I5, I6, I9, J1, J2, J3, K1, K2, K3, K4, K5, K7, K8, K9, L8, M2, M3, M4

06Commenter 22015-07-31 14:19

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

07Commenter 22015-09-03 15:53

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

08Commenter 22015-09-07 12:19

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

09Commenter 22015-09-08 12:58

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

10Commenter 102015-09-08 13:01

CR26426 is updated and ready to review and test

11Commenter 112015-09-08 18:04

Remarks:

src\BRepOffsetAPI\BRepOffsetAPI_DraftAngle.hxx:

- the following comments have duplicate sentences:
  //! Exceptions
  //! Standard_NoSuchObject if S is not the initial shape or
  //! a subshape of the initial shape to which the
  //! transformation has been applied. Raises NoSuchObject from Standard
  //! if S is not the initial shape or a sub-shape
  //! of the initial shape.

12Commenter 22015-09-08 18:25

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

13Commenter 132015-09-08 18:28

Branch CR26426 is updated according to note 45256 and ready for tests

14Commenter 142015-09-10 16:15

Dear Commenter 1,

Branch CR26426 from occt git-repository (and master from products git-repository) was compiled on Linux and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 15 (15 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 39 (39 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
http://occt-tests/CR26426-master-occt-64/Debian70-64/summary.html
draft angle G1, J3

Testing on Linux:
Total MEMORY difference: 91159555 / 91940613 [-0.85%]
Total CPU difference: 17848.559999999103 / 17715.28999999897 [+0.75%]

Testing on Windows:
Total MEMORY difference: 57135643 / 57144818 [-0.02%]
Total CPU difference: 16435.500955098993 / 16584.559910599328 [-0.90%]

15Commenter 22015-10-21 14:05

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

16Commenter 162015-10-21 14:09

Branch CR26426 was updated in order to merge fixes for 26426 and 26396

17Commenter 172015-10-21 14:09

Branch CR26426 was updated in order to merge fixes for 26426 and 26396
Please test it.

18Commenter 182015-10-22 14:49

Dear Commenter 1,

Branch CR26426 from occt git-repository (and master from products git-repository) was compiled on Linux, Windows and MacOS platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 8 (8 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 39 (39 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
http://occt-tests/CR26426-master-occt-64/Debian70-64/summary.html
draft angle G1, G6, J2, J3

Testing on Linux:
Total MEMORY difference: 92096228 / 92266300 [-0.18%]
Total CPU difference: 19666.079999999798 / 19656.73999999973 [+0.05%]

Testing on Windows:
Total MEMORY difference: 58026168 / 58040693 [-0.03%]
Total CPU difference: 18007.60103259898 / 17972.407206998967 [+0.20%]

19Commenter 192015-10-22 14:50

Dear ifv,

Branch [archived branch] has been rejected due to:
- regressions/differences/improvement

20Commenter 22015-10-26 14:25

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

21Commenter 212015-10-26 14:29

Branch CR26426 was updated to fix regressions, please test

22Commenter 22015-10-26 17:45

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

23Commenter 232015-10-26 17:45

Branch [archived branch] has been rebased on the current master

24Commenter 22015-10-27 15:01

Branch [archived branch] has been updated by Participant.

[revision removed]

Detailed log of new commits:

Author: apv
Date: Tue Oct 27 15:01:01 2015 +0300

Test-case for issue #0026426

25Commenter 252015-10-27 15:54

Dear Commenter 1,

Branch CR26426 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 1 (1 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 39 (39 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing cases:
bugs modalg_6 bug26426 - OK
http://occt-tests/CR26426-master-occt-64/Debian70-64/bugs/modalg_6/bug26426.html
http://occt-tests/CR26426-master-occt-64/Windows-64-VC10/bugs/modalg_6/bug26426.html

Testing on Linux:
Total MEMORY difference: 92196894 / 92336834 [-0.15%]
Total CPU difference: 19725.799999999763 / 19731.589999999687 [-0.03%]

Testing on Windows:
Total MEMORY difference: 58096060 / 58090849 [+0.01%]
Total CPU difference: 18472.047209798835 / 18494.870156099 [-0.12%]

26Commenter 22016-04-17 14:30

Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records