Archived issue #0026792
Visualization, Graphic3d - Z-fit support for transform persistence is missing after removing Visual3d_View
Description
Several lines of code of Visual3d_View::MinMaxValues implemented by #26344 are missing in current version after integration of #0024776. These lines enables support by z-fit procedure of zoom, rotate transform persistent objects.
The missing code should be merged back and test case added for this functionality.
The missing code should be merged back and test case added for this functionality.
Steps to reproduce
pload ALL
box b 100 100 100
vdisplay b -trsfPers zoom
vzoom 0.01
vzfit
box b 100 100 100
vdisplay b -trsfPers zoom
vzoom 0.01
vzfit
Public activity
15 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Wed Oct 21 13:25:57 2015 +0300
0026792: Visualization, Graphic3d - Z-fit support for transform persistence is missing after removing Visual3d_View
Add missing code for z-fit support for zoom, rotate persistent object.
Fixed wrong statement that should enable frustum culling optimization for zoom, rotate persistent object.
Added non-regression test case for z-clipping of transform persistent objects.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Wed Oct 21 13:25:57 2015 +0300
0026792: Visualization, Graphic3d - Z-fit support for transform persistence is missing after removing Visual3d_View
Add missing code for z-fit support for zoom, rotate persistent object.
Fixed wrong statement that should enable frustum culling optimization for zoom, rotate persistent object.
Added non-regression test case for z-clipping of transform persistent objects.
Dear Kirill,
Please review the patch.
Please review the patch.
Please test the patch.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Dear Commenter 1,
Branch CR26792 was rebased on branch IR-2015-10-22 of occt git-repository.
[revision removed]
Branch CR26792 was rebased on branch IR-2015-10-22 of occt git-repository.
[revision removed]
Dear Commenter 1,
Branch CR26792 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 1 (1 on master)
Windows: 0 (0 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR26792-master-occt-64/Debian70-64/bugs/vis/bug26792.html
http://occt-tests/CR26792-master-occt-64/Windows-64-VC10/bugs/vis/bug26792.html
bugs vis bug26792: OK
Testing on Linux:
occt component :
Total MEMORY difference: 92912829 / 92331080 [+0.63%]
Total CPU difference: 19673.739999999725 / 19731.34999999969 [-0.29%]
products component :
Total MEMORY difference: 26180396 / 26226349 [-0.18%]
Total CPU difference: 7750.079999999978 / 7363.820000000012 [+5.25%]
Testing on Windows:
occt component :
Total MEMORY difference: 58409217 / 58043302 [+0.63%]
Total CPU difference: 18161.324417998592 / 18133.197437699022 [+0.16%]
products component :
Total MEMORY difference: 17174870 / 17138954 [+0.21%]
Total CPU difference: 5588.080620799969 / 5652.477833599974 [-1.14%]
There are following differences in images found by testdiff.
http://occt-tests/CR26792-master-occt-64/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR26792-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html
IMAGE bugs vis bug26719_2: bug26719_2_1.png differs
IMAGE bugs vis bug26719_2: bug26719_2_Driver1_Viewer1_View1.png differs
IMAGE bugs vis bug26719_2: bug26719_2_2.png differs
IMAGE bugs vis bug23120: bug23120_Driver1_Viewer1_View1.png differs
IMAGE v3d glsl stereo: stereo_anaglyph.png differs
IMAGE v3d glsl stereo: stereo_col.png differs
IMAGE v3d glsl stereo: stereo_overunder_anamorph.png differs
IMAGE v3d glsl stereo: stereo_sbs_anamorph.png differs
IMAGE v3d glsl texture_trsf: texture_trsf.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_scale_glsl.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_ffp.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_glsl.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_translate_ffp.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_translate_glsl.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_scale_ffp.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_identity_glsl.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_identity_ffp.png differs
IMAGE caf presentation F3: F3.png differs
IMAGE caf presentation F4: F4.png differs
IMAGE caf presentation G1: G1.png differs
IMAGE caf presentation K1: K1.png differs
IMAGE caf presentation H1: H1.png differs
IMAGE caf presentation I1: I1.png differs
IMAGE caf presentation J1: J1.png differs
IMAGE caf presentation F2: F2.png differs
IMAGE bugs vis bug5988: bug5988_Driver1_Viewer1_View1.png differs
IMAGE bugs modalg_2 bug22196: bug22196_Driver1_Viewer1_View1.png differs
Branch CR26792 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 1 (1 on master)
Windows: 0 (0 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR26792-master-occt-64/Debian70-64/bugs/vis/bug26792.html
http://occt-tests/CR26792-master-occt-64/Windows-64-VC10/bugs/vis/bug26792.html
bugs vis bug26792: OK
Testing on Linux:
occt component :
Total MEMORY difference: 92912829 / 92331080 [+0.63%]
Total CPU difference: 19673.739999999725 / 19731.34999999969 [-0.29%]
products component :
Total MEMORY difference: 26180396 / 26226349 [-0.18%]
Total CPU difference: 7750.079999999978 / 7363.820000000012 [+5.25%]
Testing on Windows:
occt component :
Total MEMORY difference: 58409217 / 58043302 [+0.63%]
Total CPU difference: 18161.324417998592 / 18133.197437699022 [+0.16%]
products component :
Total MEMORY difference: 17174870 / 17138954 [+0.21%]
Total CPU difference: 5588.080620799969 / 5652.477833599974 [-1.14%]
There are following differences in images found by testdiff.
http://occt-tests/CR26792-master-occt-64/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR26792-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html
IMAGE bugs vis bug26719_2: bug26719_2_1.png differs
IMAGE bugs vis bug26719_2: bug26719_2_Driver1_Viewer1_View1.png differs
IMAGE bugs vis bug26719_2: bug26719_2_2.png differs
IMAGE bugs vis bug23120: bug23120_Driver1_Viewer1_View1.png differs
IMAGE v3d glsl stereo: stereo_anaglyph.png differs
IMAGE v3d glsl stereo: stereo_col.png differs
IMAGE v3d glsl stereo: stereo_overunder_anamorph.png differs
IMAGE v3d glsl stereo: stereo_sbs_anamorph.png differs
IMAGE v3d glsl texture_trsf: texture_trsf.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_scale_glsl.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_ffp.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_glsl.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_translate_ffp.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_translate_glsl.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_scale_ffp.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_identity_glsl.png differs
IMAGE v3d glsl texture_trsf: texture_trsf_identity_ffp.png differs
IMAGE caf presentation F3: F3.png differs
IMAGE caf presentation F4: F4.png differs
IMAGE caf presentation G1: G1.png differs
IMAGE caf presentation K1: K1.png differs
IMAGE caf presentation H1: H1.png differs
IMAGE caf presentation I1: I1.png differs
IMAGE caf presentation J1: J1.png differs
IMAGE caf presentation F2: F2.png differs
IMAGE bugs vis bug5988: bug5988_Driver1_Viewer1_View1.png differs
IMAGE bugs modalg_2 bug22196: bug22196_Driver1_Viewer1_View1.png differs
Dear apl,
Branch [archived branch] has been rejected due to:
- differences in images
Branch [archived branch] has been rejected due to:
- differences in images
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Nov 19 11:16:14 2015 +0300
0026792: Visualization, Graphic3d - Z-fit support for transform persistence is missing after removing Visual3d_View
Add missing code for z-fit support for zoom, rotate persistent object.
Fixed wrong statement that should enable frustum culling optimization for zoom, rotate persistent object.
Fixed BVH_LinearBuilder.lxx to correctly control number of items in leaf node for a case of items with equal bounding boxes.
Added non-regression test case for z-clipping of transform persistent objects.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Nov 19 11:16:14 2015 +0300
0026792: Visualization, Graphic3d - Z-fit support for transform persistence is missing after removing Visual3d_View
Add missing code for z-fit support for zoom, rotate persistent object.
Fixed wrong statement that should enable frustum culling optimization for zoom, rotate persistent object.
Fixed BVH_LinearBuilder.lxx to correctly control number of items in leaf node for a case of items with equal bounding boxes.
Added non-regression test case for z-clipping of transform persistent objects.
Dear Kirill,
Please review branch CR26792_1. There is one more fix for BVH_LinearBuilder.
Please review branch CR26792_1. There is one more fix for BVH_LinearBuilder.
Please test updated patch.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been rebased on the current master
Dear Commenter 1,
Branch CR26792_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS: 127 (127 on master)
products component:
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences:
Not detected
Testing cases:
bugs vis bug26792 - OK
http://occt-tests/CR26792-1-master-occt-64/Debian70-64/bugs/vis/bug26792.html
http://occt-tests/CR26792-1-master-occt-64/Windows-64-VC10/bugs/vis/bug26792.html
Testing on Linux:
Total MEMORY difference: 93273976 / 93571288 [-0.32%]
Total CPU difference: 19934.789999999786 / 19980.139999999952 [-0.23%]
Testing on Windows:
Total MEMORY difference: 58370922 / 58378770 [-0.01%]
Total CPU difference: 18489.30092039909 / 18194.47463049887 [+1.62%]
Branch CR26792_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS: 127 (127 on master)
products component:
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences:
Not detected
Testing cases:
bugs vis bug26792 - OK
http://occt-tests/CR26792-1-master-occt-64/Debian70-64/bugs/vis/bug26792.html
http://occt-tests/CR26792-1-master-occt-64/Windows-64-VC10/bugs/vis/bug26792.html
Testing on Linux:
Total MEMORY difference: 93273976 / 93571288 [-0.32%]
Total CPU difference: 19934.789999999786 / 19980.139999999952 [-0.23%]
Testing on Windows:
Total MEMORY difference: 58370922 / 58378770 [-0.01%]
Total CPU difference: 18489.30092039909 / 18194.47463049887 [+1.62%]
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Commenter 2.
[revision removed]
[revision removed]
Related records