DiscussionsIssue archiveOCCT:Visualization

Archived issue #0026960

Visualization, TKOpenGl - update transformation of dynamically highlighted presentation

Open CASCADEOCCT:Visualizationclosed14 public notes

Search issues

Description

Presentation manager does not update transformation of shadow structure used for dynamical highlighting causing visual artifacts.

Steps to reproduce

pload VISUALIZATION MODELING
box b 1 2 3
vclear
vinit View1
vdisplay -dispmode 1 -highmode 1 b
vfit
vmoveto 250 250
vsetlocation b 0.5 0 0
vreadpixel 100 100 rgb name
# expected color: BLACK
# actual color: CYAN1

Public activity

14 archived notes

Participants are labeled by their role within this record.

01Commenter 3
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Dec 7 14:32:31 2015 +0300

    0026960: Visualization, TKOpenGl - update transformation of dynamically highlighted presentation
    
    OpenGl_StructureShadow::Render() - take transformation of parent structure on each redraw.
02Commenter 3
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: vpa
Date: Fri Dec 18 21:29:13 2015 +0300

    0026960: Visualization, TKOpenGl - update transformation of dynamically highlighted presentation
    
    - added method UpdateHighlightTrsf for immediate update of highlight presentation's transformation;
    - interfaces for immediate transformation update of corresponding presentations were added to entity owner classes;
    - test case for issue #0026960
03Commenter 3
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
04Commenter 4
Dear Kirill,

please review patch in branch CR26960_1.
05Author
Please test the patch.
06Commenter 6
Dear Commenter 1,

Branch CR26960_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 134 (134 on master)
products component:
   Linux: 37 (37 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
http://occt-tests/CR26960-1-master-occt-64/Debian70-64/summary.html
http://occt-tests/CR26960-1-master-occt-64/Windows-64-VC10/summary.html
bugs vis bug25335

Testing cases:
bugs modalg_6 bug26619 - FAILED
http://occt-tests/CR26960-1-master-occt-64/Debian70-64/bugs/vis/bug26960.html
http://occt-tests/CR26960-1-master-occt-64/Windows-64-VC10/bugs/vis/bug26960.html

Testing on Linux:
Total MEMORY difference: 89377741 / 89698264 [-0.36%]
Total CPU difference: 19382.730000000007 / 19353.560000000063 [+0.15%]

Testing on Windows:
Total MEMORY difference: 54647666 / 54642917 [+0.01%]
Total CPU difference: 17683.00975189883 / 18198.733457798822 [-2.83%]
07Commenter 7
Dear vpa,

Branch [archived branch] has been rejected due to:
- regressions/differences/improvements
- failed test-case for issue
08Commenter 3
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
09Commenter 9
Dear Commenter 1,

regressions were fixed. Please, test updated branch CR26960_1.
10Commenter 3
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
11Commenter 11
Branch [archived branch] has been rebased on the current master
12Commenter 12
Dear Commenter 1,

Branch CR26960_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 134 (134 on master)
products component:
   Linux: 37 (37 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detetced

Testing cases:
bugs modalg_6 bug26619 - OK
http://occt-tests/CR26960-1-master-occt-64/Debian70-64/bugs/vis/bug26960.html
http://occt-tests/CR26960-1-master-occt-64/Windows-64-VC10/bugs/vis/bug26960.html

Testing on Linux:
Total MEMORY difference: 89214935 / 89703996 [-0.55%]
Total CPU difference: 19214.97000000001 / 19353.80000000006 [-0.72%]

Testing on Windows:
Total MEMORY difference: 56930203 / 54607088 [+4.25%]
Total CPU difference: 17836.65513679898 / 18177.31452049882 [-1.87%]
13Commenter 3
Branch [archived branch] has been deleted by Author.

[revision removed]
14Commenter 3
Branch [archived branch] has been deleted by Author.

[revision removed]

Related records