The tolerance reached by approximator is used in creation of an edge, it is incorrect

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Jun 2 10:34:12 2017 +0300

    0028802: The tolerance reached by approximator is used in creation of an edge, it is incorrect
    
    Method IntTools_FaceFace::MakeCurve is modified: tolerances of approximator are now not taken into account.

Please review the branch CR28802.

Dear Julia, the patch looks OK, but it can lead to regressions. Please continue development to provide non-regression state.

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Jun 6 13:09:27 2017 +0300

    0028802: The tolerance reached by approximator is used in creation of an edge, it is incorrect
    
    Method IntTools_FaceFace::MakeCurve is modified: reached tolerances 2d and 3d of approximator are not used for edges.

Please test the branch CR28802_1.

Branch [archived branch] has been created by Author.

[revision removed]


No new revisions were added by this update.

Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Jun 6 15:34:43 2017 +0300

    0028802: The tolerance reached by approximator is used in creation of an edge, it is incorrect
    
        Method IntTools_FaceFace::MakeCurve is modified: reached tolerances 2d and 3d of approximator are not used for edges.

Dear Commenter 1,
Branch CR28802_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1200

Regressions/Differences/Improvements:
http://occt-tests/CR28802_1-master-OCCT/Debian70-64/summary.html
http://occt-tests/CR28802_1-master-OCCT/Windows-64-VC10/summary.html
Failed:
  boolean bsection M3
  bugs modalg_6 bug26896_1
  bugs modalg_6 bug26896_3
  bugs modalg_6 bug27310_2
  bugs modalg_6 bug28718

Only on Linux platform:
http://occt-tests/CR28802_1-master-OCCT/Debian70-64/summary.html
Failed:
  bugs modalg_6 bug26938_1
  bugs modalg_6 bug26938_2
  bugs modalg_6 bug26938_3

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 92936996 / 91760125 [+1.28%]
Total CPU difference: 19084.760000000217 / 18743.900000000256 [+1.82%]
products component :
Total MEMORY difference: 33624533 / 33639153 [-0.04%]
Total CPU difference: 6207.320000000083 / 6199.250000000062 [+0.13%]
Testing on Windows:
occt component :
Total MEMORY difference: 58851628 / 58848397 [+0.01%]
Total CPU difference: 17724.038014898728 / 17514.55987209864 [+1.20%]
products component :
Total MEMORY difference: 24290653 / 24251584 [+0.16%]
Total CPU difference: 6224.29949910006 / 6213.800631800075 [+0.17%]

There are following differences in images found by testdiff.
http://occt-tests/CR28802_1-master-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR28802_1-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE boolean bsection N4: N4.png differs
IMAGE bugs modalg_1 bug10232: bug10232.png differs

Dear jgv,
Branch [archived branch] has been rejected due to:
- regressions/differences/improvements
- differences in images

Dear Commenter 1,
Branch CR28802_2 from occt git-repository (and CR27079-26 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1205

Regressions/Differences/Improvements:
http://occt-tests/CR28802_2-CR27079-26-OCCT/Debian70-64/summary.html
http://occt-tests/CR28802_2-CR27079-26-OCCT/Windows-64-VC10/summary.html
Failed:
  boolean bsection M3
  bugs modalg_6 bug26896_1
  bugs modalg_6 bug26896_3
  bugs modalg_6 bug27310_2
  bugs modalg_6 bug28718

Only on Linux platform:
http://occt-tests/CR28802_2-CR27079-26-OCCT/Debian70-64/summary.html
Failed:
  bugs modalg_6 bug26938_1
  bugs modalg_6 bug26938_2
  bugs modalg_6 bug26938_3

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 92039230 / 91761650 [+0.30%]
Total CPU difference: 19016.17000000023 / 19335.060000000096 [-1.65%]
products component :
Total MEMORY difference: 31222137 / 31244557 [-0.07%]
Total CPU difference: 5360.709999999982 / 5296.999999999966 [+1.20%]
Testing on Windows:
occt component :
Total MEMORY difference: 58500211 / 58497831 [+0.00%]
Total CPU difference: 17458.47751259858 / 17520.28510879866 [-0.35%]
products component :
Total MEMORY difference: 22726658 / 22688363 [+0.17%]
Total CPU difference: 5386.168526499981 / 5357.885545199975 [+0.53%]

There are following differences in images found by testdiff.
http://occt-tests/CR28802_2-CR27079-26-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR28802_2-CR27079-26-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE boolean bsection N4: N4.png differs
IMAGE bugs modalg_1 bug10232: bug10232.png differs

Dear jgv,
Branch [archived branch] has been rejected due to:
- regressions/differences/improvements
- differences in images

All the changes are improvements in fact (decrease of tolerances of resulting shapes), except

bugs modalg_6 bug26938_*

only on Linux.

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Jun 9 15:21:04 2017 +0300

    0028802: The tolerance reached by approximator is used in creation of an edge, it is incorrect
    
        Method IntTools_FaceFace::MakeCurve is modified: reached tolerances 2d and 3d of approximator are not used for edges.

Dear Andrey,

the branch CR28802_3 is based on CR27079-26.

It is agreed that problem with tests bugs modalg_6 bug26938_* on Linux should be addressed in context of separate issue, #0028833.

Thus please accept branch CR28802_3 for integration, adding Linux-only TODOs for these tests and updating tests listed in note #0028802 (decreased value of tolerance).

Dear Commenter 1,
Branch CR28802_3 from occt git-repository and CR27079-26 from products git-repository was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1211

Regressions/Differences/Improvements:
http://occt-tests/CR28802_3-CR27079-26-OCCT/Debian70-64/summary.html
http://occt-tests/CR28802_3-CR27079-26-OCCT/Windows-64-VC10/summary.html
Failed:
  boolean bsection M3
  bugs modalg_6 bug26896_1
  bugs modalg_6 bug26896_3
  bugs modalg_6 bug27310_2
  bugs modalg_6 bug28718

Only on Linux platform:
http://occt-tests/CR28802_3-CR27079-26-OCCT/Debian70-64/summary.html
Failed:
  bugs modalg_6 bug26938_1
  bugs modalg_6 bug26938_2
  bugs modalg_6 bug26938_3

Testing cases:
http://occt-tests/CR28802_3-CR27079-26-OCCT/Windows-64-VC10/boolean/bsection/N4.html
boolean bsection N4: OK
TOTAL CPU TIME: 214.6729761 sec (210.8197514 sec - on current master)

Testing on Linux:
occt component :
Total MEMORY difference: 92111350 / 92092166 [+0.02%]
Total CPU difference: 18915.890000000265 / 18989.35000000035 [-0.39%]
products component :
Total MEMORY difference: 33578139 / 33656232 [-0.23%]
Total CPU difference: 6257.7400000000725 / 6179.4300000000685 [+1.27%]
Testing on Windows:
occt component :
Total MEMORY difference: 58686112 / 58684365 [+0.00%]
Total CPU difference: 17755.846618798554 / 17488.726106498834 [+1.53%]
products component :
Total MEMORY difference: 24263890 / 24224898 [+0.16%]
Total CPU difference: 6293.501542700072 / 6164.207913900061 [+2.10%]

There are following differences in images found by testdiff.
http://occt-tests/CR28802_3-CR27079-26-OCCT/Debian70-64/diff-Debian70-64-image.html
http://occt-tests/CR28802_3-CR27079-26-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE boolean bsection N4: N4.png differs
IMAGE bugs modalg_6 bug26938_2: bug26938_2.png differs - only on Linux platform
IMAGE bugs modalg_6 bug26938_3: bug26938_3.png differs - only on Linux platform
IMAGE bugs modalg_6 bug26938_1: bug26938_1.png differs - only on Linux platform

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkv
Date: Wed Jun 14 17:13:23 2017 +0300

    // Small correction of test cases for issue CR28802

Dear Commenter 1,
Branch CR28802_3 from occt git-repository and branch CR27079-26 from products git-repository are TESTED.

Dear Commenter 1,
following test cases are corrected and pushed to the branch CR28802_3 of occt git-repository:
  boolean bsection M3
  bugs modalg_6 bug26896_1
  bugs modalg_6 bug26896_3
  bugs modalg_6 bug27310_2
  bugs modalg_6 bug28718
  bugs modalg_6 bug26938_1
  bugs modalg_6 bug26938_2
  bugs modalg_6 bug26938_3

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]