OCCT3D
DiscussionsIssue archiveOCCT:Visualization

Archived issue #0030716

Visualization - change default polygon offset units property from 0.0 to 1.0

Open CASCADEOCCT:Visualizationclosed6 public notes

Search issues

Description

Currently the default constructor of Graphic3d_PolygonOffset class sets the value of its Units property to 0.0f and it is a default setting used in ShadingAspect of Prs3d_Drawer class. But there are some situations when the plane which visualized triangles and segments are located in is parallel to the view plane and segments are hided behind triangles. Standard mechanisms of solving of such problem (like setting the display priority for Prs3d_Presentation objects) may be not applicable or easy to implement. However it is obvious that edges should not be hided behind triangles almost always in such situations. So it would be appropriate to change the default value of the Units property of Graphic3d_PolygonOffset class to 1.0f.

Steps to reproduce

Not required

Public activity

6 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: tiv
Date: Fri May 17 12:01:01 2019 +0300

     0030716: Visualization - Set polygon offset units property to 1.0
    
    The default value of the Units property of the Graphic3d_PolygonOffset class is changed to 1.0f (instead of 0.0f used previously).
02Commenter 2
Patch is ready for review: http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR30716-master-TIV/view/ALL/
03Commenter 3
Please raise the patch.
04Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16381.320000000025 / 16346.709999999983 [+0.21%]
Products
Total CPU difference: 10503.220000000054 / 10516.200000000064 [-0.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 17743.859375 / 17692.25 [+0.29%]
Products
Total CPU difference: 12066.390625 / 12107.796875 [-0.34%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
05Commenter 5
The problem with appearance of arrows in dimension objects will be fixed in #0030721.

06Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records