Archived issue #0032337
Visualization - rename Overlaps() method in selection to more self-describable names
Description
Selection defines numerous overloaded methods called Overlaps() for point, AABB, triangle, segment.
Although it is possible deducing the method purpose from the list of its arguments, this is not straight-forward and might be misleading in some cases.
It is proposed renaming these methods to have primitive type in the name.
Overlaps() might be preserved for compatibility redirecting to new ones.
Although it is possible deducing the method purpose from the list of its arguments, this is not straight-forward and might be misleading in some cases.
It is proposed renaming these methods to have primitive type in the name.
Overlaps() might be preserved for compatibility redirecting to new ones.
Steps to reproduce
Not required
Public activity
23 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
Solution Implementation, Testing
Please also handle
> Overlaps() might be preserved for compatibility redirecting to new ones.
Overlaps() methods should be preserved at high-level API (e.g. SelectMgr_SelectingVolumeManager class) as non-virtual deprecated methods redirected to new methods.
Please also check compilation of samples, OCC Products and start Jenkins job.
> Overlaps() might be preserved for compatibility redirecting to new ones.
Overlaps() methods should be preserved at high-level API (e.g. SelectMgr_SelectingVolumeManager class) as non-virtual deprecated methods redirected to new methods.
Please also check compilation of samples, OCC Products and start Jenkins job.
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Thu May 13 12:46:29 2021 +0300
# kgv remarks:
- restored Overlaps() methods as non-virtual and deprecated
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Thu May 13 12:46:29 2021 +0300
# kgv remarks:
- restored Overlaps() methods as non-virtual and deprecated
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
Solution implementation
Please rebase patch on top of #0032365.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
Solution implementation
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Mon May 24 12:36:41 2021 +0300
# kgv remarks
- moved deprecated methods to the end of file
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Mon May 24 12:36:41 2021 +0300
# kgv remarks
- moved deprecated methods to the end of file
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
[revision removed]
Detailed log of new commits:
Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
- renamed Overlaps and hasOverlap overloaded methods to self-describable names
Solution implementation, Testing
Please raise the patch
- OCCT: branch CR32337_4;
- OCC Products: branch CR32337_2.
- OCCT: branch CR32337_4;
- OCC Products: branch CR32337_2.
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17574.5700000004 / 17867.41000000037 [-1.64%]
Products
Total CPU difference: 11533.700000000124 / 11535.680000000108 [-0.02%]
Windows-64-VC14:
OCCT
Total CPU difference: 19393.5625 / 19367.75 [+0.13%]
Products
Total CPU difference: 12891.8125 / 12920.9375 [-0.23%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17574.5700000004 / 17867.41000000037 [-1.64%]
Products
Total CPU difference: 11533.700000000124 / 11535.680000000108 [-0.02%]
Windows-64-VC14:
OCCT
Total CPU difference: 19393.5625 / 19367.75 [+0.13%]
Products
Total CPU difference: 12891.8125 / 12920.9375 [-0.23%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records