Archived issue #0032419

Coding Rules - revert Overlaps() methods to SelectBasics_SelectingVolumeManager as deprecated aliases

Open CASCADEOCCT:Codingclosed5 public notes

Search issues

Description

Porting existing code to #0032337 shows compilations errors.
This is because SelectBasics_SelectingVolumeManager::Overlaps() have been removed without deprecation step.

Steps to reproduce

N/A

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Jun 4 11:28:49 2021 +0300

    0032419: Coding Rules - revert Overlaps() methods to SelectBasics_SelectingVolumeManager as deprecated aliases
    
    Deprecated Overlaps() methods have been moved from subclass SelectMgr_SelectingVolumeManager
    to the base class SelectBasics_SelectingVolumeManager,
    so that they are actually accessible within Select3D_SensitiveEntity::Matches() implementations.
    
    Several methods have been marked as pure virtual in the base interface.
    Second SelectMgr_BaseIntersector::OverlapsPolygon() has been dropped from virtual interface
    as useless (trivially replaceable).
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Author
Please raise the patch
- OCCT: branch CR32419;
- OCC Products: branch CR32419.

http://jenkins-test-occt.nnov.opencascade.com/view/CR32419-CR32419-KGV/
04Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17503.060000000427 / 17574.5700000004 [-0.41%]
Products
Total CPU difference: 11532.860000000106 / 11533.700000000124 [-0.01%]
Windows-64-VC14:
OCCT
Total CPU difference: 19219.09375 / 19393.5625 [-0.90%]
Products
Total CPU difference: 12831.25 / 12891.8125 [-0.47%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
05Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records